Attention is currently required from: Henry Sun, Karthik Ramasubramanian.
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52286 )
Change subject: mb/google/dedede/var/galith: support Audio AMP I2C/Auto mode
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/dedede/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/52286/comment/ed5b3ac4_43ff1de0
PS2, Line 13: field AUDIO_AMP 14 16
: option UNPROVISIONED 0
: option MAX98360 1
: option RT1015_I2C 2
: option RT1015P_AUTO 3
: end
Done
If coreboot add "| UNPROVISIONED" cause build fail
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb169c69a6716082dd218d05479bca46bbc09a3e
Gerrit-Change-Number: 52286
Gerrit-PatchSet: 4
Gerrit-Owner: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 14 Apr 2021 07:58:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment