Daniel Kang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: proto2 PO debug ......................................................................
mb/google/volteer: proto2 PO debug
Temporay patch for ov2740 user-facing camera debugging
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I3b51826e123dec394c1b4eb9a1c5b64b8b11459e --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/41157/1
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl old mode 100644 new mode 100755 index 83d711b..548eefe --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -125,7 +125,7 @@ Package (0x02) { "data-lanes", - Package (0x04) + Package (0x02) { One, 0x02 @@ -583,7 +583,7 @@ "link-frequencies", Package (0x01) { - 0xABA9500 + 0x15752A00 } }, Package (0x02)
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41157
to look at the new patch set (#2).
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
mb/google/volteer: Fix camera dsdt config for ov2740
Link frequncy and a format was not correct for volteer proto 2 ov2740 user-facing camera.
BUG=b:148428976 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check user-facing camera functionalities
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I3b51826e123dec394c1b4eb9a1c5b64b8b11459e --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/41157/2
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 2: Code-Review+1
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 2:
This is temporary fix until SSDT replace DSDT.
Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 2: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@9 PS2, Line 9: frequncy frequency
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@10 PS2, Line 10: ov2740 user-facing camera. Where did you get the new values from?
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@15 PS2, Line 15: and check user-facing camera functionalities Please add a dot/period at the end.
Daniel H Kang has uploaded a new patch set (#3) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
mb/google/volteer: Fix camera dsdt config for ov2740
Link frequency and a format was not correct for volteer proto 2 ov2740 user-facing camera.
BUG=b:148428976 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check user-facing camera functionalities.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I3b51826e123dec394c1b4eb9a1c5b64b8b11459e --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/41157/3
Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 3: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@9 PS2, Line 9: frequncy
frequency
Done
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@10 PS2, Line 10: ov2740 user-facing camera.
Where did you get the new values from?
1920*1080*60fps*10bps/2lanes/2(double data rate) = 311MHz. Here we need to add some overhead. Typical overhead is 35% but here we have little less.
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@15 PS2, Line 15: and check user-facing camera functionalities
Please add a dot/period at the end.
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@10 PS2, Line 10: ov2740 user-facing camera.
1920*1080*60fps*10bps/2lanes/2(double data rate) = 311MHz. Here we need to add some overhead. […]
It’d be great if you added that to the commit message. (Please add spaces.)
Daniel H Kang has uploaded a new patch set (#4) to the change originally created by Daniel Kang. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
mb/google/volteer: Fix camera dsdt config for ov2740
Link frequency and a format was not correct for volteer proto 2 ov2740 user-facing camera.
The link frequency is calculated in the following way. (max frame width * max frame height * max fps * data format in bps / number of lanes / data rate) + max 35% of overhead For ov2740, (1920 * 1080 * 60 * 10 / 2 / 2) = 311Mhz. 360Mhz after adding 18% of overhead.
BUG=b:148428976 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check user-facing camera functionalities.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I3b51826e123dec394c1b4eb9a1c5b64b8b11459e --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/41157/4
Daniel H Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@10 PS2, Line 10: ov2740 user-facing camera.
It’d be great if you added that to the commit message. (Please add spaces. […]
Done
Hello build bot (Jenkins), Patrick Georgi, Wonkyu Kim, Caveh Jalali, Alex Levin, Nick Vaccaro, Furquan Shaikh, Daniel H Kang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41157
to look at the new patch set (#5).
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
mb/google/volteer: Fix camera dsdt config for ov2740
Link frequency and a format was not correct for volteer proto 2 ov2740 user-facing camera.
The link frequency is calculated in the following way. (max frame width * max frame height * max fps * data format in bps / number of lanes / data rate) + max 35% of overhead For ov2740, (1920 * 1080 * 60 * 10 / 2 / 2) = 311Mhz. 360Mhz after adding 18% of overhead.
BUG=b:148428976 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check user-facing camera functionalities.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I3b51826e123dec394c1b4eb9a1c5b64b8b11459e --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/41157/5
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 5: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 5: Code-Review+1
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 5:
Could you merge this patch if there is no further comments?
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41157/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/41157/5/src/mainboard/google/voltee... PS5, Line 586: 0x15752A00 What is this encoding? Could you add a comment?
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 5: Code-Review+1
Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 5:
(1 comment)
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41157/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/41157/5/src/mainboard/google/voltee... PS5, Line 586: 0x15752A00
What is this encoding? Could you add a comment?
0x15752A00 = 360,000,000 in decimal, which is 360MHz.
Dossym Nurmukhanov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 5: Code-Review+2
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
mb/google/volteer: Fix camera dsdt config for ov2740
Link frequency and a format was not correct for volteer proto 2 ov2740 user-facing camera.
The link frequency is calculated in the following way. (max frame width * max frame height * max fps * data format in bps / number of lanes / data rate) + max 35% of overhead For ov2740, (1920 * 1080 * 60 * 10 / 2 / 2) = 311Mhz. 360Mhz after adding 18% of overhead.
BUG=b:148428976 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check user-facing camera functionalities.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I3b51826e123dec394c1b4eb9a1c5b64b8b11459e Reviewed-on: https://review.coreboot.org/c/coreboot/+/41157 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Dossym Nurmukhanov dossym@google.com Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Wonkyu Kim: Looks good to me, approved Dossym Nurmukhanov: Looks good to me, approved Daniel Kang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index 92c0339..777ab7a 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -124,7 +124,7 @@ Package (0x02) { "data-lanes", - Package (0x04) + Package (0x02) { One, 0x02 @@ -582,7 +582,7 @@ "link-frequencies", Package (0x01) { - 0xABA9500 + 0x15752A00 } }, Package (0x02)
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
Patch Set 6:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3666 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3665 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3664 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3663
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Alex Levin (Code Review)
-
Daniel H Kang (Code Review)
-
Daniel Kang (Code Review)
-
Dossym Nurmukhanov (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Wonkyu Kim (Code Review)