Change in coreboot[master]: mainboard/google/kahlee: allow oem.bin file to update smbios
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/28651 )
Change subject: mainboard/google/kahlee: allow oem.bin file to update smbios ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/28651/1/src/mainboard/google/kahlee/variants... File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:
https://review.coreboot.org/#/c/28651/1/src/mainboard/google/kahlee/variants... PS1, Line 93: const char *smbios_mainboard_manufacturer(void) ah, it looks like nami already does this. Should we extract the struct and method into a common file?
https://review.coreboot.org/#/c/28651/1/src/mainboard/google/kahlee/variants... PS1, Line 111: It might be easier to read if you calculated the number of oem_entries and just did a for loop over the count.
-
Raul Rangel (Code Review)