Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37311 )
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
mb/google/poppy: add VBTs for remaining variants
Add VBT files for Atlas, Nocturne, Rammus, and Soraka variants. Extracted from ChromeOS recovery images for the respective boards.
Change-Id: Icba2741e0b7309c22c027f956cd20cec78f34052 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/poppy/Kconfig A src/mainboard/google/poppy/variants/atlas/data.vbt A src/mainboard/google/poppy/variants/nocturne/data.vbt A src/mainboard/google/poppy/variants/rammus/data.vbt A src/mainboard/google/poppy/variants/soraka/data.vbt 5 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/37311/1
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index e8fb38d..9fafef7 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -10,7 +10,6 @@ select EC_GOOGLE_CHROMEEC_ESPI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES - select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_NAMI || BOARD_GOOGLE_NAUTILUS select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select SOC_INTEL_KABYLAKE @@ -145,6 +144,7 @@ select EXCLUDE_NATIVE_SD_INTERFACE select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR select INCLUDE_NHLT_BLOBS_ATLAS if USE_BLOBS + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_SPI_TPM_CR50 select VARIANT_HAS_CAMERA_ACPI
@@ -163,6 +163,7 @@ select DRIVERS_SPI_ACPI select EXCLUDE_NATIVE_SD_INTERFACE select INCLUDE_NHLT_BLOBS_NAMI if USE_BLOBS + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_SPI_TPM_CR50
config VARIANT_SPECIFIC_OPTIONS_NAUTILUS @@ -171,6 +172,7 @@ select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_DA7219 select INCLUDE_NHLT_BLOBS_NAUTILUS if USE_BLOBS + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_I2C_TPM_CR50 select VARIANT_HAS_CAMERA_ACPI
@@ -185,6 +187,7 @@ select EXCLUDE_NATIVE_SD_INTERFACE select GEO_SAR_ENABLE if CHROMEOS_WIFI_SAR select INCLUDE_NHLT_BLOBS_NOCTURNE if USE_BLOBS + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_SPI_TPM_CR50 select NO_FADT_8042 select VARIANT_HAS_CAMERA_ACPI @@ -197,6 +200,7 @@ select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI select INCLUDE_NHLT_BLOBS_RAMMUS if USE_BLOBS + select INTEL_GMA_HAVE_VBT select MAINBOARD_HAS_SPI_TPM_CR50
config VARIANT_SPECIFIC_OPTIONS_SORAKA @@ -204,6 +208,7 @@ select DRIVERS_I2C_MAX98927 select NO_FADT_8042 select MAINBOARD_HAS_I2C_TPM_CR50 + select INTEL_GMA_HAVE_VBT select VARIANT_HAS_CAMERA_ACPI
config VBOOT diff --git a/src/mainboard/google/poppy/variants/atlas/data.vbt b/src/mainboard/google/poppy/variants/atlas/data.vbt new file mode 100644 index 0000000..850375e --- /dev/null +++ b/src/mainboard/google/poppy/variants/atlas/data.vbt Binary files differ diff --git a/src/mainboard/google/poppy/variants/nocturne/data.vbt b/src/mainboard/google/poppy/variants/nocturne/data.vbt new file mode 100644 index 0000000..4d9293e --- /dev/null +++ b/src/mainboard/google/poppy/variants/nocturne/data.vbt Binary files differ diff --git a/src/mainboard/google/poppy/variants/rammus/data.vbt b/src/mainboard/google/poppy/variants/rammus/data.vbt new file mode 100644 index 0000000..5fc6e1c --- /dev/null +++ b/src/mainboard/google/poppy/variants/rammus/data.vbt Binary files differ diff --git a/src/mainboard/google/poppy/variants/soraka/data.vbt b/src/mainboard/google/poppy/variants/soraka/data.vbt new file mode 100644 index 0000000..4156bde --- /dev/null +++ b/src/mainboard/google/poppy/variants/soraka/data.vbt Binary files differ
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37311 )
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
Patch Set 1: Code-Review+2
Hello Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37311
to look at the new patch set (#2).
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
mb/google/poppy: add VBTs for remaining variants
Add VBT files for Atlas, Nocturne, Rammus, and Soraka variants. Extracted from ChromeOS recovery images for the respective boards.
Change-Id: Icba2741e0b7309c22c027f956cd20cec78f34052 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/poppy/Kconfig A src/mainboard/google/poppy/variants/atlas/data.vbt A src/mainboard/google/poppy/variants/nocturne/data.vbt A src/mainboard/google/poppy/variants/rammus/data.vbt A src/mainboard/google/poppy/variants/soraka/data.vbt 5 files changed, 6 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/37311/2
Hello Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37311
to look at the new patch set (#3).
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
mb/google/poppy: add VBTs for remaining variants
Add VBT files for Atlas, Nocturne, Rammus, and Soraka variants. Extracted from ChromeOS recovery images for the respective boards.
Alphabetize config options selected by each variant since we're already touching them.
Change-Id: Icba2741e0b7309c22c027f956cd20cec78f34052 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/poppy/Kconfig A src/mainboard/google/poppy/variants/atlas/data.vbt A src/mainboard/google/poppy/variants/nocturne/data.vbt A src/mainboard/google/poppy/variants/rammus/data.vbt A src/mainboard/google/poppy/variants/soraka/data.vbt 5 files changed, 11 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/37311/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37311 )
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
Patch Set 3: Code-Review+1
Not sure if all boards select INTEL_GMA_HAVE_VBT now
Hello Angel Pons, Arthur Heymans, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37311
to look at the new patch set (#4).
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
mb/google/poppy: add VBTs for remaining variants
Add VBT files for Atlas, Nocturne, Rammus, and Soraka variants. Extracted from ChromeOS recovery images for the respective boards. Select INTEL_GMA_HAVE_VBT for all variants except Poppy, since it doesn't have a VBT (or a recovery image from which to extract one).
Change-Id: Icba2741e0b7309c22c027f956cd20cec78f34052 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/poppy/Kconfig A src/mainboard/google/poppy/variants/atlas/data.vbt A src/mainboard/google/poppy/variants/nocturne/data.vbt A src/mainboard/google/poppy/variants/rammus/data.vbt A src/mainboard/google/poppy/variants/soraka/data.vbt 5 files changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/37311/4
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37311 )
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37311 )
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
mb/google/poppy: add VBTs for remaining variants
Add VBT files for Atlas, Nocturne, Rammus, and Soraka variants. Extracted from ChromeOS recovery images for the respective boards. Select INTEL_GMA_HAVE_VBT for all variants except Poppy, since it doesn't have a VBT (or a recovery image from which to extract one).
Change-Id: Icba2741e0b7309c22c027f956cd20cec78f34052 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37311 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/poppy/Kconfig A src/mainboard/google/poppy/variants/atlas/data.vbt A src/mainboard/google/poppy/variants/nocturne/data.vbt A src/mainboard/google/poppy/variants/rammus/data.vbt A src/mainboard/google/poppy/variants/soraka/data.vbt 5 files changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/poppy/Kconfig b/src/mainboard/google/poppy/Kconfig index 85dc9a5..30e5263 100644 --- a/src/mainboard/google/poppy/Kconfig +++ b/src/mainboard/google/poppy/Kconfig @@ -10,7 +10,7 @@ select EC_GOOGLE_CHROMEEC_ESPI select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES - select INTEL_GMA_HAVE_VBT if BOARD_GOOGLE_NAMI || BOARD_GOOGLE_NAUTILUS + select INTEL_GMA_HAVE_VBT if !BOARD_GOOGLE_POPPY select INTEL_LPSS_UART_FOR_CONSOLE select MAINBOARD_HAS_CHROMEOS select SOC_INTEL_KABYLAKE diff --git a/src/mainboard/google/poppy/variants/atlas/data.vbt b/src/mainboard/google/poppy/variants/atlas/data.vbt new file mode 100644 index 0000000..850375e --- /dev/null +++ b/src/mainboard/google/poppy/variants/atlas/data.vbt Binary files differ diff --git a/src/mainboard/google/poppy/variants/nocturne/data.vbt b/src/mainboard/google/poppy/variants/nocturne/data.vbt new file mode 100644 index 0000000..4d9293e --- /dev/null +++ b/src/mainboard/google/poppy/variants/nocturne/data.vbt Binary files differ diff --git a/src/mainboard/google/poppy/variants/rammus/data.vbt b/src/mainboard/google/poppy/variants/rammus/data.vbt new file mode 100644 index 0000000..5fc6e1c --- /dev/null +++ b/src/mainboard/google/poppy/variants/rammus/data.vbt Binary files differ diff --git a/src/mainboard/google/poppy/variants/soraka/data.vbt b/src/mainboard/google/poppy/variants/soraka/data.vbt new file mode 100644 index 0000000..4156bde --- /dev/null +++ b/src/mainboard/google/poppy/variants/soraka/data.vbt Binary files differ
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37311 )
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
Patch Set 5:
Matt, have you verified the dmesg logging for the atlas and nocturne variants?
The vbt on these boards differs from the others (the config size is 39 vs 38 bytes). I have a similar vbt (Kabylake FSP 3.7.1. or newer) and get an error message indicating the configsize reported by the VBT is not correct.
This at least doesn't look nice. Before reporting this to Intel I wanted to make sure I am not the only one with this problem.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37311 )
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
Patch Set 5:
Patch Set 5:
Matt, have you verified the dmesg logging for the atlas and nocturne variants?
The vbt on these boards differs from the others (the config size is 39 vs 38 bytes). I have a similar vbt (Kabylake FSP 3.7.1. or newer) and get an error message indicating the configsize reported by the VBT is not correct.
This at least doesn't look nice. Before reporting this to Intel I wanted to make sure I am not the only one with this problem.
I don't have Atlas here, but on Nocturne I do see a log entry (not flagged as an error) with drm debugging enabled for function parse_general_definitions: 'Expected child device config size for VBT version 221 not known; assuming 39.' I'm not seeing any functional impairment though. FSP (KBL 3.7.6) doesn't seem to have an issue though, both internal and external displays are initialized correctly at boot.
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37311 )
Change subject: mb/google/poppy: add VBTs for remaining variants ......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 5:
Matt, have you verified the dmesg logging for the atlas and nocturne variants?
The vbt on these boards differs from the others (the config size is 39 vs 38 bytes). I have a similar vbt (Kabylake FSP 3.7.1. or newer) and get an error message indicating the config size reported by the VBT is not correct.
This at least doesn't look nice. Before reporting this to Intel I wanted to make sure I am not the only one with this problem.
I don't have Atlas here, but on Nocturne I do see a log entry (not flagged as an error) with drm debugging enabled for function parse_general_definitions: 'Expected child device config size for VBT version 221 not known; assuming 39.' I'm not seeing any functional impairment though. FSP (KBL 3.7.6) doesn't seem to have an issue though, both internal and external displays are initialized correctly at boot.
Thanks for the feednack, so you are seeing the same thing. You are right it's not a problem functionality wise. At least not at this point in time. The additional byte is not copied so nothing is overwritten and the additional byte (DP max link speed) is not used yet in the BSF but the output looks ugly and is intended to trigger some action. So I will report it to Intel.
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)
-
Wim Vervoorn (Code Review)