Attention is currently required from: Bora Guvendik, Martin Roth, Paul Menzel, Subrata Banik, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51446 )
Change subject: soc/intel/alderlake: Inject Pre-CPU reset TS into timestamp_table ......................................................................
Patch Set 5:
(5 comments)
File src/soc/intel/alderlake/telemetry.c:
https://review.coreboot.org/c/coreboot/+/51446/comment/d187b300_dd89c679 PS5, Line 20: bool I'm not sure `bool` has a well-defined size for say, 32-bit and 64-bit code, and this is an ABI as well, I think you should use all fixed-size integers in an ABI.
https://review.coreboot.org/c/coreboot/+/51446/comment/e436a1d2_3c8cd2e5 PS5, Line 37: u16 time_stamp_6_ms; same
https://review.coreboot.org/c/coreboot/+/51446/comment/c5f4e517_ef2b3e78 PS5, Line 31: u32 time_stamp_0_ms; : u16 time_stamp_1_ms; : u16 time_stamp_2_ms; : u16 time_stamp_3_ms; : u16 time_stamp_4_ms; : u16 time_stamp_5_ms; : u16 time_stamp_6_ms; : } mbp_perf_data; doesn't this need to be packed as well?
https://review.coreboot.org/c/coreboot/+/51446/comment/ef8e35f4_1d961ef7 PS5, Line 42: bool more bool
https://review.coreboot.org/c/coreboot/+/51446/comment/1de9c3aa_537cbdda PS5, Line 97: for (; hob && hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = fsp_next_hob(hob)) { : if (hob->type != HOB_TYPE_GUID_EXTENSION) : continue; : : res = fsp_hob_header_to_resource(hob); : : if (fsp_guid_compare(res->owner_guid, fsp_me_bios_payload_hob_guid)) { : get_pre_reset_ts_from_hob(hob); : return; : } : } I think this just could be: ``` size_t hob_size; const me_bios_payload_hob *mbp_hob = fsp_find_extension_hob_by_guid(fsp_me_bios_payload_hob_guid, &hob_size); if (mbp_hob) get_pre_reset_ts_from_hob(mbp_hob); ```