[M] Change in coreboot[main]: soc/intel/cmn/blk: Refactor CSE status flag and optimize forced sync

[Dinesh Gehlot (Code Review)]

Attention is currently required from: Intel coreboot Reviewers, Kapil Porwal, Subrata Banik.

Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/86153?usp=email )

Change subject: soc/intel/cmn/blk: Refactor CSE status flag and optimize forced sync
......................................................................

Patch Set 15:

(5 comments)

Patchset:

PS13:
> can you please combine CB:86152 CL into CB:86153

Acknowledged

Commit Message:

https://review.coreboot.org/c/coreboot/+/86153/comment/f6561275_bf107a4f?usp... :
PS14, Line 7: Remove boot partition check for forced cse sync
> this code does more things than this commit title

Acknowledged

File src/soc/intel/common/block/cse/cse_lite.c:

https://review.coreboot.org/c/coreboot/+/86153/comment/a2aa6541_1cd92245?usp... :
PS12, Line 751: 	if ((vb2api_gbb_get_flags(ctx) & VB2_GBB_FLAG_FORCE_CSE_SYNC) &&
              : 		 cse_get_current_bp() == RO) {
> > The current flag-based implementation has backward compatibility and will always function regardle […]

We use `is_cse_sync_enforced()` to determine if a forced CSE sync is pending, regardless of the boot partition. In the case of a RW boot, it is the sole indicator to switch to the RO boot partition.

Please note, ESOL has a separate check and will only appear if booting from RO, even if is_cse_sync_enforced() returns true.

https://review.coreboot.org/c/coreboot/+/86153/comment/14e44807_9e430131?usp... :
PS12, Line 765: is_cse_sync_enforced
> > The ESOL screen function at romstage also calls `is_cse_sync_enforced()`. […]

The status update has been decoupled from is_cse_sync_enforced() as `cmos_update_cse_sync_status()`. It is being called from all the

https://review.coreboot.org/c/coreboot/+/86153/comment/23e5c7e0_8c1088fd?usp... :
PS12, Line 792: n cse_info_in_cmos.cse_sync_status & CSE_ENFORCED_SYNC_REQ;
> > Yes, the sync status update exhibits a distinct behavior and warrants relocation to a dedicated fu […]

The `is_cse_sync_enforced` and `cmos_update_cse_sync_status` has been decoupled.