Change in coreboot[master]: mb/google/volteer:intel/common/block: Move mainboard api to tcss comm...

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Furquan Shaikh, Paul Menzel, Sridhar Siricilla, Deepti Deshatty, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54733 )

Change subject: mb/google/volteer:intel/common/block: Move mainboard api to tcss common block
......................................................................

Patch Set 7: Code-Review+2

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/54733/comment/3e7716e7_44becdea 
PS7, Line 6: 
           : mb/google/volteer:intel/common/block: Move mainboard api to tcss common block
`intel/common/block` is enough of a prefix

https://review.coreboot.org/c/coreboot/+/54733/comment/f0c660bf_81f38722 
PS7, Line 9: As per the comments in CB:54090  mainboard api
           : mainboard_tcss_get_port_info() is simplified and moved
           : to tcss common block code.
This text should be 72 characters wide

Patchset:

PS7: 
Looks good Deepti, just a few nits 😊

File src/drivers/intel/pmc_mux/conn/chip.h:

https://review.coreboot.org/c/coreboot/+/54733/comment/1118ca18_3162c820 
PS7, Line 32: 			
nit: line up with `const struct device...`

File src/soc/intel/common/block/tcss/tcss.c:

https://review.coreboot.org/c/coreboot/+/54733/comment/54815359_44285219 
PS7, Line 346: static struct tcss_port_map port_map[MAX_TYPE_C_PORTS];
nit: place static variables first in the declaration order

https://review.coreboot.org/c/coreboot/+/54733/comment/ea86d36a_0c966f96 
PS7, Line 349: 
nit: extra blank line

https://review.coreboot.org/c/coreboot/+/54733/comment/1a88fbd6_0c39b64a 
PS7, Line 352: {.type = DEVICE_PATH_GENERIC, .generic.id = 0, .generic.subid = 0},
good catch, I forgot about that one 😊