Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38050 )
Change subject: device/early_smbus: Remove unused prototypes ......................................................................
device/early_smbus: Remove unused prototypes
Change-Id: Iecc6591244781e092132a058fe888f3bdd78cc50 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/include/device/early_smbus.h 1 file changed, 0 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/38050/1
diff --git a/src/include/device/early_smbus.h b/src/include/device/early_smbus.h index 651dc18..c2a2f67 100644 --- a/src/include/device/early_smbus.h +++ b/src/include/device/early_smbus.h @@ -49,23 +49,8 @@
#include <stdint.h>
-/** - * \brief printk macro for SMBus debugging - */ -#if CONFIG(DEBUG_SMBUS) -#define printsmbus(x, ...) printk(BIOS_DEBUG, x, ##__VA_ARGS__) -#else -#define printsmbus(x, ...) -#endif - -u32 smbus_get_device(void); -void smbus_reset(u32 smbus_dev); -int smbus_print_error(u32 smbus_dev, u8 host_status, int loops); -int smbus_is_busy(u32 smbus_dev); -int smbus_wait_until_ready(u32 smbus_dev); u16 smbus_read_word(u32 smbus_dev, u8 addr, u8 offset); u8 smbus_read_byte(u32 smbus_dev, u8 addr, u8 offset); u8 smbus_write_byte(u32 smbus_dev, u8 addr, u8 offset, u8 value); -void smbus_delay(void);
#endif /* DEVICE_EARLY_SMBUS_H */
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38050 )
Change subject: device/early_smbus: Remove unused prototypes ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38050 )
Change subject: device/early_smbus: Remove unused prototypes ......................................................................
device/early_smbus: Remove unused prototypes
Change-Id: Iecc6591244781e092132a058fe888f3bdd78cc50 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38050 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/include/device/early_smbus.h 1 file changed, 0 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/include/device/early_smbus.h b/src/include/device/early_smbus.h index 651dc18..c2a2f67 100644 --- a/src/include/device/early_smbus.h +++ b/src/include/device/early_smbus.h @@ -49,23 +49,8 @@
#include <stdint.h>
-/** - * \brief printk macro for SMBus debugging - */ -#if CONFIG(DEBUG_SMBUS) -#define printsmbus(x, ...) printk(BIOS_DEBUG, x, ##__VA_ARGS__) -#else -#define printsmbus(x, ...) -#endif - -u32 smbus_get_device(void); -void smbus_reset(u32 smbus_dev); -int smbus_print_error(u32 smbus_dev, u8 host_status, int loops); -int smbus_is_busy(u32 smbus_dev); -int smbus_wait_until_ready(u32 smbus_dev); u16 smbus_read_word(u32 smbus_dev, u8 addr, u8 offset); u8 smbus_read_byte(u32 smbus_dev, u8 addr, u8 offset); u8 smbus_write_byte(u32 smbus_dev, u8 addr, u8 offset, u8 value); -void smbus_delay(void);
#endif /* DEVICE_EARLY_SMBUS_H */
-
Angel Pons (Code Review) -
Kyösti Mälkki (Code Review)