Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31815
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
mb/google/hatch: Add GPIO_A8 for Pen detect function
Add GPIO_A8 for pen detect function.
BUG=b:122765828 TEST=flash BIOS and using switch to verify GPIO_A8 value change.
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ie7c888ea61dd61e60c1d184565bd95e6b03777be --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/gpio.c 3 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31815/1
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 2290d8c..8e9ab9c 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -6,6 +6,7 @@ select DRIVERS_I2C_HID select DRIVERS_SPI_ACPI select DRIVERS_USB_ACPI + select DRIVERS_GENERIC_GPIO_KEYS select EC_GOOGLE_CHROMEEC select EC_GOOGLE_CHROMEEC_LPC select HAVE_ACPI_RESUME diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index e2c3392..885105e 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -220,7 +220,17 @@ device i2c 49 on end end end # I2C #1 - device pci 15.2 on end # I2C #2 + device pci 15.2 on + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_LOW(GPP_A8)" + register "key.dev_name" = ""EJCT"" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + device generic 0 on end + end + end # I2C #2 device pci 15.3 on end # I2C #3 device pci 16.0 on end # Management Engine Interface 1 device pci 16.1 off end # Management Engine Interface 2 diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 35dd912..d66328b 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -30,8 +30,8 @@ PAD_CFG_GPI_APIC(GPP_A6, NONE, DEEP, LEVEL, NONE), /* A7 : PP3300_SOC_A */ PAD_NC(GPP_A7, NONE), - /* A8 : EMR_GARAGE_DET ==> NC */ - PAD_NC(GPP_A8, NONE), + /* A8 : PEN_EJECT(notifications) */ + PAD_CFG_GPI_GPIO_DRIVER(GPP_A8, UP_20K, DEEP), /* A9 : ESPI_CLK */ /* A10 : PEN_RESET_ODL */ PAD_NC(GPP_A10, NONE),
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31815
to look at the new patch set (#2).
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
mb/google/hatch: Add GPIO_A8 for Pen detect function
Add GPIO_A8 for pen detect function.
BUG=b:122765828 TEST=flash BIOS and using switch to verify GPIO_A8 value change.
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ie7c888ea61dd61e60c1d184565bd95e6b03777be --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/gpio.c 3 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31815/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 34: GPP_A8 This is currently being removed. Let's not merge this change.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 34: GPP_A8
This is currently being removed. Let's not merge this change.
Please disregard this. We will have a pen_eject signal.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/Kconfig@9 PS2, Line 9: DRIVERS_GENERIC_GPIO_KEYS Can you please add this in alphabetical order?
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 230: register "key.label" = ""pen_eject"" Are you planning to add wake support later on?
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 34: UP_20K Why is the pull-up required here? There is already an external pull-up on this line.
Hello Paul Menzel, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31815
to look at the new patch set (#3).
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
mb/google/hatch: Add GPIO_A8 for Pen detect function
Add GPIO_A8 for pen detect function.
BUG=b:122765828 TEST=flash BIOS and using switch to verify GPIO_A8 value change.
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ie7c888ea61dd61e60c1d184565bd95e6b03777be --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/gpio.c 3 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31815/3
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 3:
(3 comments)
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/Kconfig@9 PS2, Line 9: DRIVERS_GENERIC_GPIO_KEYS
Can you please add this in alphabetical order?
Done
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 230: register "key.label" = ""pen_eject""
Are you planning to add wake support later on?
I am not sure the behavior definition. Can you give me some suggestion?
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 34: UP_20K
Why is the pull-up required here? There is already an external pull-up on this line.
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 230: register "key.label" = ""pen_eject""
I am not sure the behavior definition. […]
Do you mean how to test it?
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 230: register "key.label" = ""pen_eject""
Do you mean how to test it?
I mean the behavior needs wake support or not.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 230: register "key.label" = ""pen_eject""
I mean the behavior needs wake support or not.
Yes, pen eject is supposed to be a wake source.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 230: register "key.label" = ""pen_eject""
Yes, pen eject is supposed to be a wake source.
Do I need to add "key.is_wakeup_source", "key.wake", "key.wakeup_event_action" ?
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/2/src/mainboard/google/hatch/variants/... PS2, Line 230: register "key.label" = ""pen_eject""
Do I need to add "key.is_wakeup_source", "key.wake", "key. […]
Yes, but it looks like EMR_GARAGE_DET is not dual-routed. Let's skip the wake for now and we can revisit this later.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 3: Code-Review+2
Furquan Shaikh has removed a vote on this change.
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Removed Code-Review+2 by Furquan Shaikh furquan@google.com
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... PS3, Line 236: ACPI_GPIO_INPUT_ACTIVE_LOW Isn't this active high? What is the value of GPP_A8 when pen is inserted? and when is removed?
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... PS3, Line 33: PEN_EJECT Can you please update the name to match the net name in schematics?
Hello Paul Menzel, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31815
to look at the new patch set (#4).
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
mb/google/hatch: Add GPIO_A8 for Pen detect function
Add GPIO_A8 for pen detect function.
BUG=b:122765828 TEST=flash BIOS and using switch to verify GPIO_A8 value change.
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ie7c888ea61dd61e60c1d184565bd95e6b03777be --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/gpio.c 3 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31815/4
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 4:
(2 comments)
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... PS3, Line 236: ACPI_GPIO_INPUT_ACTIVE_LOW
Isn't this active high? What is the value of GPP_A8 when pen is inserted? and when is removed?
Pen in chromebook => GPP_A8=High , Pen not in chromebook => GPP_A8=Low
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... PS3, Line 33: PEN_EJECT
Can you please update the name to match the net name in schematics?
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... PS3, Line 236: ACPI_GPIO_INPUT_ACTIVE_LOW
Pen in chromebook => GPP_A8=High , Pen not in chromebook => GPP_A8=Low
This signal is pen inserted. Since GPP_A8 is high when pen is inserted in chromebook, this gpio should be configured to ACPI_GPIO_INPUT_ACTIVE_HIGH.
What does evtest look like when you insert/eject pen?
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 4:
(1 comment)
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... PS3, Line 236: ACPI_GPIO_INPUT_ACTIVE_LOW
This signal is pen inserted. […]
It only has a switch on proto to test now. When you press the switch, the value of evtest is 0. When you release the switch, the value of evtest is 1.
Hello Evan Green, Tim Wawrzynczak, Paul Menzel, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31815
to look at the new patch set (#5).
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
mb/google/hatch: Add GPIO_A8 for Pen detect function
Add GPIO_A8 for pen detect function.
BUG=b:122765828 TEST=flash BIOS and using switch to verify GPIO_A8 value change.
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ie7c888ea61dd61e60c1d184565bd95e6b03777be --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/gpio.c 3 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31815/5
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/31815/3/src/mainboard/google/hatch/variants/... PS3, Line 236: ACPI_GPIO_INPUT_ACTIVE_LOW
It only has a switch on proto to test now. When you press the switch, the value of evtest is 0. […]
Correct. So, as you indicated, pen inserted i.e. switch press thus GPP_A8 goes high. When pen is ejected i.e. switch released thus GPP_A8 goes low.
From Linux kernel perspective, this GPIO key is interpreted as "Pen inserted" indicated by the switch event SW_PEN_INSERTED (https://chromium.googlesource.com/chromiumos/third_party/kernel/+/refs/heads...). As the defintion says, insert is indicated by set. Thus, the gpio is active high i.e. when pen is inserted, the gpio reads high, so evtest should read high. When pen is ejected, gpio reads low and so evtest should read low.
So, it should be configured as ACPI_GPIO_INPUT_ACTIVE_HIGH.
Hello Evan Green, Tim Wawrzynczak, Paul Menzel, Shelley Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31815
to look at the new patch set (#6).
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
mb/google/hatch: Add GPIO_A8 for Pen detect function
Add GPIO_A8 for pen detect function.
BUG=b:122765828 TEST=flash BIOS and using switch to verify GPIO_A8 value change.
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ie7c888ea61dd61e60c1d184565bd95e6b03777be --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/gpio.c 3 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/31815/6
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31815 )
Change subject: mb/google/hatch: Add GPIO_A8 for Pen detect function ......................................................................
mb/google/hatch: Add GPIO_A8 for Pen detect function
Add GPIO_A8 for pen detect function.
BUG=b:122765828 TEST=flash BIOS and using switch to verify GPIO_A8 value change.
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: Ie7c888ea61dd61e60c1d184565bd95e6b03777be Reviewed-on: https://review.coreboot.org/c/coreboot/+/31815 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/gpio.c 3 files changed, 14 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index 19c7184..b551065 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -2,6 +2,7 @@ config BOARD_GOOGLE_BASEBOARD_HATCH def_bool n select BOARD_ROMSIZE_KB_32768 + select DRIVERS_GENERIC_GPIO_KEYS select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index 0399dc1..bda6e2a 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -236,7 +236,17 @@ device i2c 49 on end end end # I2C #1 - device pci 15.2 on end # I2C #2 + device pci 15.2 on + chip drivers/generic/gpio_keys + register "name" = ""PENH"" + register "gpio" = "ACPI_GPIO_INPUT_ACTIVE_HIGH(GPP_A8)" + register "key.dev_name" = ""EJCT"" + register "key.linux_code" = "SW_PEN_INSERTED" + register "key.linux_input_type" = "EV_SW" + register "key.label" = ""pen_eject"" + device generic 0 on end + end + end # I2C #2 device pci 15.3 on chip drivers/i2c/sx9310 register "desc" = ""SAR Proximity Sensor"" diff --git a/src/mainboard/google/hatch/variants/baseboard/gpio.c b/src/mainboard/google/hatch/variants/baseboard/gpio.c index 73d6645..3d6be33 100644 --- a/src/mainboard/google/hatch/variants/baseboard/gpio.c +++ b/src/mainboard/google/hatch/variants/baseboard/gpio.c @@ -30,8 +30,8 @@ PAD_CFG_GPI_APIC(GPP_A6, NONE, DEEP, LEVEL, NONE), /* A7 : PP3300_SOC_A */ PAD_NC(GPP_A7, NONE), - /* A8 : EMR_GARAGE_DET ==> NC */ - PAD_NC(GPP_A8, NONE), + /* A8 : EMR_GARAGE_DET */ + PAD_CFG_GPI_GPIO_DRIVER(GPP_A8, NONE, DEEP), /* A9 : ESPI_CLK */ /* A10 : PEN_RESET_ODL */ PAD_NC(GPP_A10, NONE),
-
Dtrain Hsu (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)