Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44550 )
Change subject: util/abuild: Avoid another git submodule invocation ......................................................................
util/abuild: Avoid another git submodule invocation
.xcompile is generated before the submodules handling, but there's no need for the submodules to be around, so skip here, too.
Change-Id: I60205f65b124a09067de5ae50f066b5cf64733f2 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M util/abuild/abuild 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/44550/1
diff --git a/util/abuild/abuild b/util/abuild/abuild index 903a569..f90e2b3 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -769,7 +769,7 @@ exit 1 fi
-$MAKE -C"${ROOT}" .xcompile || exit 1 +$MAKE -C"${ROOT}" UPDATED_SUBMODULES=1 .xcompile || exit 1
customizing=$(echo "$customizing" | cut -c3-) if [ "$customizing" = "" ]; then
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44550 )
Change subject: util/abuild: Avoid another git submodule invocation ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44550 )
Change subject: util/abuild: Avoid another git submodule invocation ......................................................................
util/abuild: Avoid another git submodule invocation
.xcompile is generated before the submodules handling, but there's no need for the submodules to be around, so skip here, too.
Change-Id: I60205f65b124a09067de5ae50f066b5cf64733f2 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44550 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M util/abuild/abuild 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved
diff --git a/util/abuild/abuild b/util/abuild/abuild index 903a569..f90e2b3 100755 --- a/util/abuild/abuild +++ b/util/abuild/abuild @@ -769,7 +769,7 @@ exit 1 fi
-$MAKE -C"${ROOT}" .xcompile || exit 1 +$MAKE -C"${ROOT}" UPDATED_SUBMODULES=1 .xcompile || exit 1
customizing=$(echo "$customizing" | cut -c3-) if [ "$customizing" = "" ]; then
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44550 )
Change subject: util/abuild: Avoid another git submodule invocation ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8 "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/15860 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/15859 "QEMU x86 i440fx/piix4" using payload SeaBIOS : FAIL : https://lava.9esec.io/r/15858 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/15857 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/15856 "HP Z220 SFF Workstation" using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/15863 "HP Compaq 8200 Elite SFF PC" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/15862 "HP Compaq 8200 Elite SFF PC" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/15861
Please note: This test is under development and might not be accurate at all!
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44550 )
Change subject: util/abuild: Avoid another git submodule invocation ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44550/2/util/abuild/abuild File util/abuild/abuild:
https://review.coreboot.org/c/coreboot/+/44550/2/util/abuild/abuild@799 PS2, Line 799: git submodule update --checkout --init What about this one? It pulls in all submodules, including amd_blobs and qc_blobs
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)