Change in ...coreboot[master]: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Bora Guvendik (Code Review)

26 Jun 2019 26 Jun '19

10:33 p.m.

Bora Guvendik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33818

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake

Update FSP header files with 7.0.64.40 version for Cannonlake platform.

Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FsptUpd.h 4 files changed, 6,400 insertions(+), 6,381 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/33818/1

Attachments:

attachment.htm (text/html — 1.9 KB)

Show replies by date

Bora Guvendik (Code Review)

26 Jun 26 Jun

10:44 p.m.

Bora Guvendik has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake

Update FSP header files with 7.0.64.40 version for Cannonlake platform.

Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FsptUpd.h 3 files changed, 6,440 insertions(+), 6,333 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/33818/2

Bora Guvendik (Code Review)

10:50 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33818

to look at the new patch set (#3).

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake

Update FSP header files with 7.0.64.40 version for Cannonlake platform.

Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h 2 files changed, 176 insertions(+), 69 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/33818/3

Paul Menzel (Code Review)

27 Jun 27 Jun

4:32 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/33818/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33818/3//COMMIT_MSG@10 PS3, Line 10: Please add a summary of the changes (change-log).

Bora Guvendik (Code Review)

28 Jun 28 Jun

12:21 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33818

to look at the new patch set (#4).

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake

Update FSP header files with 7.0.64.40 version for Cannonlake platform, the following changes were made, Silicon Init UPD: 1. Add UPD to disable Heci1. 2. Add CD clock selections of 675MHz. 3. Add UPD to program GT Chicken bits. 4. Add various xHCI USB related UPDs. 5. Teton Glacier Cycle Router UPD deprecated. 6. CdynmaxClampEnable is enabled by default now. 7. Add UPDs for C3 Cstate Demotion. Memory Init UPD: 1. Add GDXC configuration options. 2. Remove some internal graphics memory selections. 3. Remove Fixed mid option for SaGv. 4. Add DualDimm per channel board type. 5. Add UPD for DDR4 mixed U-DIMM 2DPC Limitation. 6. Add UPD to skip DDR4 refresh. 7. Add UPD for Lpddr Dram Odt.

Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h 2 files changed, 176 insertions(+), 69 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/33818/4

Bora Guvendik (Code Review)

12:25 a.m.

Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

Patch Set 4:

(1 comment)

...

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/33818/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/33818/3//COMMIT_MSG@10 PS3, Line 10:

...

Please add a summary of the changes (change-log).

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 4 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 27 Jun 2019 22:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Lijian Zhao (Code Review)

2:22 a.m.

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 4 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 28 Jun 2019 00:22:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Bora Guvendik (Code Review)

2:27 a.m.

Hello Subrata Banik, Selma Bensaid, Duncan Laurie, Lijian Zhao, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33818

to look at the new patch set (#5).

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake

Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h 2 files changed, 176 insertions(+), 69 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/33818/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 5 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Subrata Banik (Code Review)

6:33 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

Patch Set 5: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 5 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 28 Jun 2019 04:33:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

10:52 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

Patch Set 5:

(2 comments)

Looks good, but there's two things that look odd to me.

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... File src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h:

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... PS5, Line 2298: : : : : : : : : : : : : : : : This change is not listed in the commit message

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... File src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h:

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... PS5, Line 853: Chickent Chicken

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 5 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 28 Jun 2019 08:52:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Bora Guvendik (Code Review)

2 Jul 2 Jul

8:36 a.m.

Hello Subrata Banik, Selma Bensaid, Duncan Laurie, build bot (Jenkins), Lijian Zhao, Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33818

to look at the new patch set (#6).

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake

Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Signed-off-by: Bora Guvendik bora.guvendik@intel.com --- M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h M src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h 2 files changed, 176 insertions(+), 69 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/33818/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Bora Guvendik (Code Review)

8:37 a.m.

Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

Patch Set 6:

(2 comments)

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... File src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspmUpd.h:

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... PS5, Line 2298: : : : : : : : : : : : : : : :

...

This change is not listed in the commit message

Done

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... File src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h:

https://review.coreboot.org/#/c/33818/5/src/vendorcode/intel/fsp/fsp2_0/cann... PS5, Line 853: Chickent

...

Chicken

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 02 Jul 2019 06:37:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

1:40 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

Patch Set 6: Code-Review+1

(1 comment)

No idea, if the typos should be fixed upstream to not diverge.

https://review.coreboot.org/#/c/33818/6/src/vendorcode/intel/fsp/fsp2_0/cann... File src/vendorcode/intel/fsp/fsp2_0/cannonlake/FspsUpd.h:

https://review.coreboot.org/#/c/33818/6/src/vendorcode/intel/fsp/fsp2_0/cann... PS6, Line 854: Progarm the GT chicken bits in GTTMMADR + 0xD00 BITS [3:1] Program

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Tue, 02 Jul 2019 11:40:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

4:16 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

Patch Set 6:

...

Patch Set 6: Code-Review+1

(1 comment)

No idea, if the typos should be fixed upstream to not diverge.

Ideally, I think it would be good to fix the typos upstream. Less divergence would make it easy to sync in the future.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Tue, 02 Jul 2019 14:16:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

4:23 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

Patch Set 6: Code-Review+1

...

Patch Set 6:

...
Patch Set 6: Code-Review+1

(1 comment)

No idea, if the typos should be fixed upstream to not diverge.

Ideally, I think it would be good to fix the typos upstream. Less divergence would make it easy to sync in the future.

I agree.

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 02 Jul 2019 14:23:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Bora Guvendik (Code Review)

9 Jul 9 Jul

11:35 p.m.

New subject: Change in coreboot[master]: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake

Bora Guvendik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33818 )

Change subject: vendorcode/intel/fsp/fsp2_0/cnl: Update FSP header files for Cannonlake ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/33818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If71e5fb8ae9f48a232b6b507e19145e1c06c2e83 Gerrit-Change-Number: 33818 Gerrit-PatchSet: 6 Gerrit-Owner: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Bora Guvendik bora.guvendik@intel.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Lijian Zhao lijian.zhao@intel.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Selma Bensaid selma.bensaid@intel.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

1954

days inactive

1967

days old

coreboot-gerrit@coreboot.org

15 comments

6 participants

tags (0)

participants (6)

Angel Pons (Code Review)
Bora Guvendik (Code Review)
Furquan Shaikh (Code Review)
Lijian Zhao (Code Review)
Paul Menzel (Code Review)
Subrata Banik (Code Review)