Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/19258 )
Change subject: sb/intel/*: Use common SMBus functions ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/#/c/19258/10//COMMIT_MSG Commit Message:
Line 11: implementations with a common file.
Any reason why i82801dx is not touched?
forgot it.
its funny that it has smbus.c with supposedly ramstage functions but it is not even linked in...
Line 15: this function can reduce the time being spent to read SPD five-fold.
Revisit kernel driver about these smbus/i2c block read functions. There was
command 6 does not seem to be used by the the i801 kernel driver...
https://review.coreboot.org/#/c/19258/14/src/southbridge/intel/common/smbus.... File src/southbridge/intel/common/smbus.c:
PS14, Line 95: /* poll for it to start */ : if (smbus_wait_until_active(smbus_base) < 0) { : return -4; : } not sure if this is needed/desired...