Attention is currently required from: Cliff Huang, Eran Mitrani, Eric Lai, Jingyuan Liang, Kyoung Il Kim, Paul Menzel.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81331?usp=email )
Change subject: drivers/intel/touch: Add driver for Intel Touch Controller and Devices
......................................................................
Patch Set 5:
(2 comments)
File src/drivers/intel/touch/touch.c:
https://review.coreboot.org/c/coreboot/+/81331/comment/eb8dd085_c8cae8f9 :
PS5, Line 347: config = ((const struct device *)dev)->chip_info;
Redundant?
https://review.coreboot.org/c/coreboot/+/81331/comment/eb918e45_5d8ffd4d :
PS5, Line 358: config = ((const struct device *)dev)->chip_info;
Redundant?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81331?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I52dfcd187c92141cb8fc47f4143b90d243439d4e
Gerrit-Change-Number: 81331
Gerrit-PatchSet: 5
Gerrit-Owner: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jingyuan Liang
jingyliang@google.com
Gerrit-Reviewer: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Henry Barnor
hbarnor@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Jingyuan Liang
jingyliang@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kyoung Il Kim
kyoung.il.kim@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sun, 28 Apr 2024 11:44:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment