HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35988 )
Change subject: src: Remove unused include <device/smbus_def.h> ......................................................................
src: Remove unused include <device/smbus_def.h>
Change-Id: Idba48b2182d38dd4945044c79c393c3fd514d720 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/smbus.h M src/soc/intel/broadwell/smbus.c M src/soc/intel/broadwell/smbus_common.c M src/soc/intel/common/block/smbus/smbuslib.c M src/soc/intel/fsp_broadwell_de/smbus.c M src/soc/intel/fsp_broadwell_de/smbus_common.c M src/southbridge/amd/amd8111/amd8111_smbus.h M src/southbridge/broadcom/bcm5785/smbus.h M src/southbridge/intel/common/smbus.c M src/southbridge/nvidia/ck804/smbus.h M src/southbridge/nvidia/mcp55/smbus.h 11 files changed, 0 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/35988/1
diff --git a/src/include/device/smbus.h b/src/include/device/smbus.h index 2953b25..863bc80 100644 --- a/src/include/device/smbus.h +++ b/src/include/device/smbus.h @@ -4,7 +4,6 @@ #include <stdint.h> #include <device/device.h> #include <device/i2c_bus.h> -#include <device/smbus_def.h>
/* Common SMBus bus operations */ struct smbus_bus_operations { diff --git a/src/soc/intel/broadwell/smbus.c b/src/soc/intel/broadwell/smbus.c index 9367f33..68d3983 100644 --- a/src/soc/intel/broadwell/smbus.c +++ b/src/soc/intel/broadwell/smbus.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/path.h> #include <device/smbus.h> -#include <device/smbus_def.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/soc/intel/broadwell/smbus_common.c b/src/soc/intel/broadwell/smbus_common.c index 99ed55b..aae3095 100644 --- a/src/soc/intel/broadwell/smbus_common.c +++ b/src/soc/intel/broadwell/smbus_common.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> -#include <device/smbus_def.h> #include <device/pci.h> #include <soc/ramstage.h> #include <soc/smbus.h> diff --git a/src/soc/intel/common/block/smbus/smbuslib.c b/src/soc/intel/common/block/smbus/smbuslib.c index 0d3901f..1f211fe 100644 --- a/src/soc/intel/common/block/smbus/smbuslib.c +++ b/src/soc/intel/common/block/smbus/smbuslib.c @@ -14,7 +14,6 @@ */
#include <arch/io.h> -#include <device/smbus_def.h> #include <timer.h> #include "smbuslib.h"
diff --git a/src/soc/intel/fsp_broadwell_de/smbus.c b/src/soc/intel/fsp_broadwell_de/smbus.c index 94474f7..732d452 100644 --- a/src/soc/intel/fsp_broadwell_de/smbus.c +++ b/src/soc/intel/fsp_broadwell_de/smbus.c @@ -18,7 +18,6 @@ #include <arch/io.h> #include <device/device.h> #include <device/smbus.h> -#include <device/smbus_def.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> diff --git a/src/soc/intel/fsp_broadwell_de/smbus_common.c b/src/soc/intel/fsp_broadwell_de/smbus_common.c index e179b55..c41dfb9 100644 --- a/src/soc/intel/fsp_broadwell_de/smbus_common.c +++ b/src/soc/intel/fsp_broadwell_de/smbus_common.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> -#include <device/smbus_def.h> #include <device/pci.h> #include <soc/ramstage.h> #include <soc/smbus.h> diff --git a/src/southbridge/amd/amd8111/amd8111_smbus.h b/src/southbridge/amd/amd8111/amd8111_smbus.h index 7386965..5e87da7 100644 --- a/src/southbridge/amd/amd8111/amd8111_smbus.h +++ b/src/southbridge/amd/amd8111/amd8111_smbus.h @@ -12,7 +12,6 @@ */
#include <arch/io.h> -#include <device/smbus_def.h>
#define SMBGSTATUS 0xe0 #define SMBGCTL 0xe2 diff --git a/src/southbridge/broadcom/bcm5785/smbus.h b/src/southbridge/broadcom/bcm5785/smbus.h index 657d97d..b86ec46 100644 --- a/src/southbridge/broadcom/bcm5785/smbus.h +++ b/src/southbridge/broadcom/bcm5785/smbus.h @@ -15,7 +15,6 @@ */
#include <arch/io.h> -#include <device/smbus_def.h>
#define SMBHSTSTAT 0x0 #define SMBSLVSTAT 0x1 diff --git a/src/southbridge/intel/common/smbus.c b/src/southbridge/intel/common/smbus.c index e575abc..edfd2ae 100644 --- a/src/southbridge/intel/common/smbus.c +++ b/src/southbridge/intel/common/smbus.c @@ -18,7 +18,6 @@
#include <arch/io.h> #include <console/console.h> -#include <device/smbus_def.h> #include <stdlib.h> #include <types.h>
diff --git a/src/southbridge/nvidia/ck804/smbus.h b/src/southbridge/nvidia/ck804/smbus.h index bf0ff3c..aa4fc12 100644 --- a/src/southbridge/nvidia/ck804/smbus.h +++ b/src/southbridge/nvidia/ck804/smbus.h @@ -15,7 +15,6 @@ */
#include <arch/io.h> -#include <device/smbus_def.h>
#define SMBHSTSTAT 0x1 #define SMBHSTPRTCL 0x0 diff --git a/src/southbridge/nvidia/mcp55/smbus.h b/src/southbridge/nvidia/mcp55/smbus.h index f270452..6e3ba0e 100644 --- a/src/southbridge/nvidia/mcp55/smbus.h +++ b/src/southbridge/nvidia/mcp55/smbus.h @@ -18,7 +18,6 @@ */
#include <arch/io.h> -#include <device/smbus_def.h>
#define SMBHSTSTAT 0x1 #define SMBHSTPRTCL 0x0
Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35988
to look at the new patch set (#2).
Change subject: src: Remove unused include <device/smbus_def.h> ......................................................................
src: Remove unused include <device/smbus_def.h>
Change-Id: Idba48b2182d38dd4945044c79c393c3fd514d720 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/smbus.h M src/soc/intel/broadwell/smbus.c M src/soc/intel/fsp_broadwell_de/smbus.c M src/southbridge/broadcom/bcm5785/smbus.h M src/southbridge/nvidia/ck804/smbus.h M src/southbridge/nvidia/mcp55/smbus.h 6 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/35988/2
Hello Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35988
to look at the new patch set (#5).
Change subject: src: Remove unused include <device/smbus_def.h> ......................................................................
src: Remove unused include <device/smbus_def.h>
Change-Id: Idba48b2182d38dd4945044c79c393c3fd514d720 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/device/smbus.h M src/soc/intel/broadwell/smbus.c 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/35988/5
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35988 )
Change subject: src: Remove unused include <device/smbus_def.h> ......................................................................
Patch Set 7: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35988 )
Change subject: src: Remove unused include <device/smbus_def.h> ......................................................................
Patch Set 7: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35988 )
Change subject: src: Remove unused include <device/smbus_def.h> ......................................................................
src: Remove unused include <device/smbus_def.h>
Change-Id: Idba48b2182d38dd4945044c79c393c3fd514d720 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/35988 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/include/device/smbus.h M src/soc/intel/broadwell/smbus.c 2 files changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Frans Hendriks: Looks good to me, approved
diff --git a/src/include/device/smbus.h b/src/include/device/smbus.h index 2953b25..863bc80 100644 --- a/src/include/device/smbus.h +++ b/src/include/device/smbus.h @@ -4,7 +4,6 @@ #include <stdint.h> #include <device/device.h> #include <device/i2c_bus.h> -#include <device/smbus_def.h>
/* Common SMBus bus operations */ struct smbus_bus_operations { diff --git a/src/soc/intel/broadwell/smbus.c b/src/soc/intel/broadwell/smbus.c index 9367f33..68d3983 100644 --- a/src/soc/intel/broadwell/smbus.c +++ b/src/soc/intel/broadwell/smbus.c @@ -18,7 +18,6 @@ #include <device/device.h> #include <device/path.h> #include <device/smbus.h> -#include <device/smbus_def.h> #include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h>
-
Frans Hendriks (Code Review) -
HAOUAS Elyes (Code Review)
-
Kyösti Mälkki (Code Review)