Change in coreboot[master]: mb/clevo/kbl-u: Enable Gaussian Mixture Model PCI device

[Paul Menzel (Code Review)]

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43936 )

Change subject: mb/clevo/kbl-u: Enable Gaussian Mixture Model PCI device
......................................................................

mb/clevo/kbl-u: Enable Gaussian Mixture Model PCI device

Currently, the PCI device is not shown in GNU/Linux. But, the vendor
firmware enables it, so let’s do the same.

TEST=GMM PCI device is present:

00:08.0 System peripheral [0880]: Intel Corporation Xeon E3-1200 v5/v6 / E3-1500 v5 / 6th/7th/8th Gen Core Processor Gaussian Mixture Model [8086:1911]

Change-Id: I94d69015c86d05849d6f3cda6ac45bfabf912658
Signed-off-by: Paul Menzel 
---
M src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb
M src/mainboard/clevo/kbl-u/variants/n240bu/devicetree.cb
2 files changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/43936/1

diff --git a/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb b/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb
index a92670f..caa3973 100644
--- a/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb
+++ b/src/mainboard/clevo/kbl-u/variants/n13xwu/devicetree.cb
@@ -113,6 +113,8 @@
    	end

device pci 02.0 on end # Integrated Graphics Device
+		device pci 08.0 on end # Gaussian Mixture Model
+

device pci 14.0 on # USB xHCI
    		register "SsicPortEnable" = "0"
diff --git a/src/mainboard/clevo/kbl-u/variants/n240bu/devicetree.cb b/src/mainboard/clevo/kbl-u/variants/n240bu/devicetree.cb
index 23840cc..bb588ed 100644
--- a/src/mainboard/clevo/kbl-u/variants/n240bu/devicetree.cb
+++ b/src/mainboard/clevo/kbl-u/variants/n240bu/devicetree.cb
@@ -215,7 +215,7 @@
    		subsystemid 0x1558 0x2410 inherit
    	end
    	device pci 02.0 on  end # Integrated Graphics Device
-		device pci 08.0 off end # Gaussian Mixture Model
+		device pci 08.0 on  end # Gaussian Mixture Model
    	device pci 14.0 on  end # USB xHCI
    	device pci 14.2 on  end # Thermal Subsystem
    	device pci 16.0 off end # Management Engine Interface 1

[Paul Menzel (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43936

to look at the new patch set (#2).

Change subject: mb/clevo/kbl-u: Enable Gaussian Mixture Model PCI device
......................................................................

mb/clevo/kbl-u: Enable Gaussian Mixture Model PCI device

Currently, the PCI device is not shown in GNU/Linux. But, the vendor
firmware enables it, so let’s do the same.

TEST=GMM PCI device is present:

00:08.0 System peripheral [0880]: Intel Corporation Xeon E3-1200 v5/v6 / E3-1500 v5 / 6th/7th/8th Gen Core Processor Gaussian Mixture Model [8086:1911]

Change-Id: I94d69015c86d05849d6f3cda6ac45bfabf912658
Signed-off-by: Paul Menzel 
---
M src/mainboard/clevo/kbl-u/devicetree.cb
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/43936/2

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43936 )

Change subject: mb/clevo/kbl-u: Enable Gaussian Mixture Model PCI device
......................................................................

Patch Set 2:

Let's just do this in the initial commit?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43936 )

Change subject: mb/clevo/kbl-u: Enable Gaussian Mixture Model PCI device
......................................................................

Patch Set 2:
> Patch Set 2:
>
> Let's just do this in the initial commit?

Sure

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43936 )

Change subject: mb/clevo/kbl-u: Enable Gaussian Mixture Model PCI device
......................................................................

Patch Set 4:

This is not necessary anymore. I added this in the initial commit.

[XS] Change in coreboot[master]: mb/clevo/kbl-u: Enable Gaussian Mixture Model PCI device

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43936?usp=email )

Change subject: mb/clevo/kbl-u: Enable Gaussian Mixture Model PCI device
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.