Attention is currently required from: Máté Kukri (mkukri), Angel Pons, Michael Niewöhner, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55250 )
Change subject: [WIP] src/superio/smsc: Add support for the SCH5555 ......................................................................
Patch Set 4:
(6 comments)
Patchset:
PS4: Looks good to me, if the commit message is extended (datasheet name/revision, mentioning of RE and where/how it was tested).
File src/superio/smsc/sch5555/bootblock.c:
https://review.coreboot.org/c/coreboot/+/55250/comment/8fdc87ae_7c341ddd PS4, Line 29: * sequences could actually be sent before the serial enable function is called Please add a dot/period at the end of sentences.
https://review.coreboot.org/c/coreboot/+/55250/comment/f39d3d29_64105e6b PS4, Line 64: Setup Set up
File src/superio/smsc/sch5555/ramstage.c:
https://review.coreboot.org/c/coreboot/+/55250/comment/d6b701ab_eba15269 PS4, Line 42: * Thus we ignore the index and choose what BAR to set just based on the LDN Please add period/dot at the end of sentences.
File src/superio/smsc/sch5555/sch5555.h:
https://review.coreboot.org/c/coreboot/+/55250/comment/46215292_31047510 PS4, Line 51: // Please use
/* * */
Or just one line.
https://review.coreboot.org/c/coreboot/+/55250/comment/b9ef05a9_9857e7e0 PS4, Line 68: // Ditto.
-
Paul Menzel (Code Review)