Attention is currently required from: Sean Rhodes, Benjamin Doron, Maximilian Brune, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )
Change subject: [RFC] drivers/option: Add option list in cbtable ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS1:
The easiest way is to offload it to the developer: A Kconfig choice to use the preprocessor to choos […]
Let's stick to English for now, as other languages will need Unicode strings...
If someone else wants to add support for other languages, one could add some localisation files and have the payload use the option names as translation keys. e.g. map `primary_display` option name to "Adaptador de vídeo primario" ("Primary video adapter" in Spanish) and the corresponding help text. The data in CFR can be used as a fallback. The only thing that would require special handling are enum values: they don't have an "option name" field, so one would need to use the enum value as translation key (e.g. if `primary_display` setting "Auto" has a value of 3, the translation key could be `primary_display.enum_3`). Forms would also be a problem, as they also lack something to use as translation key (there's the UI name, though).
-
Angel Pons (Code Review)