Attention is currently required from: Elyes Haouas, Felix Singer, Martin L Roth, Paul Menzel.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85718?usp=email )
Change subject: util/crossgcc: Update DESTDIR variable use
......................................................................
Patch Set 4:
(1 comment)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/85718/comment/97856f21_0b8e2f4d?usp... :
PS2, Line 873: "$DESTDIR"
I made the change here, but I didn't make the changes on the other lines. […]
Sorry, I feel like that wasn't clear. I'm the original author of these lines, I'm not the original author of the other lines. I modified mine to meet a style guide and prevent unintended issues as described.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85718?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9eb833b11f20b72db88e4094a3297a1d8891bac2
Gerrit-Change-Number: 85718
Gerrit-PatchSet: 4
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 21 Jan 2025 16:53:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr