Change in coreboot[master]: mb/google/guybrush: If not using PCIe WWAN, disable the port - coreboot-gerrit

3 Sep 2021


      Attention is currently required from: Raul Rangel, Martin Roth, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57316 )
Change subject: mb/google/guybrush: If not using PCIe WWAN, disable the port
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57316/comment/334d5913_9c1998e8 
PS1, Line 10: and not do
            : the PCIe training.
In the next CL, it is mentioned that PCIE Training is not done at all for the WWAN port whereas here it is mentioned "no do the PCIE training if not using PCIe WWAN". This seems to be contradicting each other unless I am missing something.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57316
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79c32e4814672c03ee0821786d5be1c77fd1b410
Gerrit-Change-Number: 57316
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 02 Sep 2021 22:38:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment