Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79093?usp=email )
Change subject: nb/intel/sandybridge: Fix unitialized variable issue ......................................................................
nb/intel/sandybridge: Fix unitialized variable issue
commit 1e9601c5ef80 ("nb/intel/sandybridge: Standardize MRC vs. native SPD mapping API") introduced an uninitialized variable issue.
Change-Id: I41b081dc4c961acc04423067e29e0eabe5f17539 Found-by: Coverity CID 1524317 Signed-off-by: Jeremy Compostella jeremy.compostella@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/79093 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/northbridge/intel/sandybridge/raminit_mrc.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Felix Held: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/raminit_mrc.c b/src/northbridge/intel/sandybridge/raminit_mrc.c index a1805a2..68b02b8 100644 --- a/src/northbridge/intel/sandybridge/raminit_mrc.c +++ b/src/northbridge/intel/sandybridge/raminit_mrc.c @@ -315,7 +315,7 @@ static void spd_fill_pei_data(struct pei_data *pei_data) { struct spd_info spdi = {0}; - unsigned int i, have_memory_down; + unsigned int i, have_memory_down = 0;
mb_get_spd_map(&spdi);