Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79824?usp=email )
Change subject: mb/intel/mtlrvp: define a new config for Chrome EC ......................................................................
mb/intel/mtlrvp: define a new config for Chrome EC
Introduce new config MTL_CHROME_EC_SHARED_SPI, tailored for Chrome ECs utilizing an external shared SPI flash.
BUG=b:289783489 TEST=emerge-rex coreboot chromeos-bootimage is successful
Cq-Depend: chrome-internal:6691498 Cq-Depend: chrome-internal:6741356 Change-Id: I462c34c5adaefa37c652de293152243c58bad7c5 Signed-off-by: Deepti Deshatty deepti.deshatty@intel.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/79824 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com --- M src/mainboard/intel/mtlrvp/Kconfig 1 file changed, 7 insertions(+), 2 deletions(-)
Approvals: Eric Lai: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/intel/mtlrvp/Kconfig b/src/mainboard/intel/mtlrvp/Kconfig index c4478d1..4d59f9b 100644 --- a/src/mainboard/intel/mtlrvp/Kconfig +++ b/src/mainboard/intel/mtlrvp/Kconfig @@ -107,7 +107,8 @@ choice prompt "ON BOARD EC" default MTL_INTEL_EC if BOARD_INTEL_MTLRVP_P - default MTL_CHROME_EC if BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP_P_MCHP || BOARD_INTEL_MTLRVP4ES_P_EXT_EC + default MTL_CHROME_EC if BOARD_INTEL_MTLRVP_P_EXT_EC || BOARD_INTEL_MTLRVP4ES_P_EXT_EC + default MTL_CHROME_EC_SHARED_SPI if BOARD_INTEL_MTLRVP_P_MCHP help This option allows you to select the on board EC to use. Select whether the board has Intel EC or/and Chrome EC @@ -115,6 +116,10 @@ config MTL_CHROME_EC bool "Chrome EC with Internal SPI flash"
+config MTL_CHROME_EC_SHARED_SPI + bool "Chrome EC with External Shared SPI flash" + select MAINBOARD_USES_IFD_EC_REGION + config MTL_INTEL_EC bool "Intel EC" select EC_ACPI @@ -122,7 +127,7 @@
config VBOOT select VBOOT_LID_SWITCH - select EC_GOOGLE_CHROMEEC_SWITCHES if MTL_CHROME_EC + select EC_GOOGLE_CHROMEEC_SWITCHES if MTL_CHROME_EC || MTL_CHROME_EC_SHARED_SPI
config UART_FOR_CONSOLE int