Attention is currently required from: Bao Zheng, Felix Held, Fred Reitberger, Zheng Bao.
Hello Felix Held, Fred Reitberger, Zheng Bao, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/81255?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed: Code-Review+2 by Felix Held, Verified+1 by build bot (Jenkins)
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: amdfwtool: Set the table size only for FWs ......................................................................
amdfwtool: Set the table size only for FWs
The entry in the table has two categaries, file and pointer. For the pointer, it does not take table space. The ISH, PSP level 2, BIOS table are all the pointer type. So integration function only packs FWs located in folder amd_blobs. And only FWs increase the table size.
So the table size is only set once. Later calls only update the count and fletcher. The table has a header at least, so the size can not be 0.
The fill_dir_header can take the parameter count as 0, such PSP level 1 only with ISH-A and ISH-B. It doesn't have any file type entries.
This actually reverts https://review.coreboot.org/c/coreboot/+/78274 and adds other changes.
TEST=Identical test on all AMD SOC platform
Change-Id: I5dfbbb55912c8e37243c351427a8df89c12e5da8 Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M util/amdfwtool/amdfwtool.c 1 file changed, 38 insertions(+), 41 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/81255/7