Attention is currently required from: Hung-Te Lin, Arthur Heymans, Julius Werner, Angel Pons.
Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62561 )
Change subject: device/mmio.h: Move readXp/writeXp helpers to device/mmio.h
......................................................................
Patch Set 2:
(1 comment)
File src/arch/x86/include/arch/mmio.h:
https://review.coreboot.org/c/coreboot/+/62561/comment/72e460b9_8a448f6a
PS2, Line 8: static __always_inline uint8_t read8(const volatile void *addr)
: {
: return *((volatile uint8_t *)(addr));
: }
sorry, just realized this is actually really arch dependent, and the missing one was only read/write […]
Seems we need to keep the read64p/write64p in x86/include/arch/mmio.h? Any suggestions?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62561
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic13a94d91affb7cf65a2f22f08ea39ed671bc8e8
Gerrit-Change-Number: 62561
Gerrit-PatchSet: 2
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 05 Mar 2022 02:08:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment