Attention is currently required from: David Wu, Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Tarun, Tyler Wang.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79176?usp=email )
Change subject: mb/google/rex/var/karis: Update fw_config settings
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/rex/variants/karis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79176/comment/805aa219_5d676025 :
PS1, Line 32: THERMAL_SETTING_1
How about ```THERMAL_SOLUTION_1```?
I mean to ask what the thermal solution refers to ? like socketed board or soldered down SoC ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79176?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a8a68b2a6c42045d541690ddb111fbf617b45d6
Gerrit-Change-Number: 79176
Gerrit-PatchSet: 1
Gerrit-Owner: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Tue, 21 Nov 2023 08:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-MessageType: comment