Attention is currently required from: Cliff Huang, Felix Held, Lance Zhao, Nico Huber, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79217?usp=email )
Change subject: acpigen.c: Add resource producer functions for mmio ......................................................................
Patch Set 4:
(3 comments)
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/79217/comment/e2eb67cf_64ca620b : PS3, Line 2260: _x
Not sure if we need the `_x`. It only has meaning to me because I know the history of the code.
Done
https://review.coreboot.org/c/coreboot/+/79217/comment/863a03af_0bd68132 : PS3, Line 2310: acpigen_resource_producer_mmio64(mmio_base, mmio_limit, type_flags);
Could this if/else be generic too? That would save us half of the wrappers. i.e. a generic acpigen_resource_x_mmio() called by acpigen_resource_producer_mmio() and acpigen_resource_consumer_mmio().
Done.
https://review.coreboot.org/c/coreboot/+/79217/comment/ef81a781_b33ea106 : PS3, Line 2331:
Single empty line is more common and preferred, I think.
Done