build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28565 )
Change subject: util/board_status: Add support of CMOS values dump ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh File util/board_status/board_status.sh:
https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh@30 PS2, Line 30: # Used if nvramtool is not in default $PATH, e.g. not installed or when using `sudo` line over 80 characters
https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh@38... PS2, Line 383: if grep -q "CONFIG_USE_OPTION_TABLE=y" "${tmpdir}/${results}/config.short.txt" > /dev/null; then line over 80 characters
https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh@40... PS2, Line 407: cmd $REMOTE "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt" line over 80 characters
https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh@43... PS2, Line 437: echo "Failed to run $nvramtool_cmd. Check $PATH or" \ line over 80 characters
https://review.coreboot.org/#/c/28565/2/util/board_status/board_status.sh@44... PS2, Line 448: cmd $LOCAL "$nvramtool_cmd -a" "${tmpdir}/${results}/cmos_values.txt" line over 80 characters