HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37884 )
Change subject: drivers/ipmi/ipmi_fru: Add missing <stdlib.h> ......................................................................
drivers/ipmi/ipmi_fru: Add missing <stdlib.h>
malloc() needs <stdlib.h>
Change-Id: I0cf6a5b76543cb6dac584de6628cfc459d5a60a8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/ipmi/ipmi_fru.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/37884/1
diff --git a/src/drivers/ipmi/ipmi_fru.c b/src/drivers/ipmi/ipmi_fru.c index a5e6ea6..8be53f8 100644 --- a/src/drivers/ipmi/ipmi_fru.c +++ b/src/drivers/ipmi/ipmi_fru.c @@ -17,6 +17,8 @@ #include <console/console.h> #include <string.h> #include <delay.h> +#include <stdlib.h> + #include "ipmi_ops.h"
#define MAX_FRU_BUSY_RETRY 5
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37884 )
Change subject: drivers/ipmi/ipmi_fru: Add missing <stdlib.h> ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37884/1/src/drivers/ipmi/ipmi_fru.c File src/drivers/ipmi/ipmi_fru.c:
https://review.coreboot.org/c/coreboot/+/37884/1/src/drivers/ipmi/ipmi_fru.c... PS1, Line 125: malloc <stdlib.h>
HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/37884 )
Change subject: drivers/ipmi/ipmi_fru: Add missing <stdlib.h> ......................................................................
Removed Code-Review+2 by HAOUAS Elyes ehaouas@noos.fr
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37884 )
Change subject: drivers/ipmi/ipmi_fru: Add missing <stdlib.h> ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37884 )
Change subject: drivers/ipmi/ipmi_fru: Add missing <stdlib.h> ......................................................................
drivers/ipmi/ipmi_fru: Add missing <stdlib.h>
malloc() needs <stdlib.h>
Change-Id: I0cf6a5b76543cb6dac584de6628cfc459d5a60a8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37884 Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/ipmi/ipmi_fru.c 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved
diff --git a/src/drivers/ipmi/ipmi_fru.c b/src/drivers/ipmi/ipmi_fru.c index a5e6ea6..8be53f8 100644 --- a/src/drivers/ipmi/ipmi_fru.c +++ b/src/drivers/ipmi/ipmi_fru.c @@ -17,6 +17,8 @@ #include <console/console.h> #include <string.h> #include <delay.h> +#include <stdlib.h> + #include "ipmi_ops.h"
#define MAX_FRU_BUSY_RETRY 5
-
HAOUAS Elyes (Code Review) -
Kyösti Mälkki (Code Review)
-
Patrick Georgi (Code Review)