Change in coreboot[master]: lib/edid_fill_fb: Make framebuffer orientation to be configurable

[Julius Werner (Code Review)]

Attention is currently required from: shkim, Paul Menzel, SH Kim, Yu-Ping Wu, Karthik Ramasubramanian.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57327 )

Change subject: lib/edid_fill_fb: Make framebuffer orientation to be configurable
......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: 
I mean, I think this is the wrong way to do this. It's super inflexible and assumes that the framebuffer orientation can be known at compile time. Existing platforms which already deal with this often support multiple panels that get detected at runtime and may require different orientations, and so the mainboard code is in charge of setting the orientation (as well as of deciding whether to run display init in the first place, and with what controller). I think if the Intel platforms want to support framebuffer rotation as well they should follow the same concept, and have that decision made by mainboard code. At least in our (Chrome OS) experience display panels are one of the parts you most commonly want to multi-source and mix-and-match between boards, so Kconfigs are not a good way to model their properties.

See https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src... for an example of how this logic flows on an existing board.