Change in coreboot[master]: HACK trogdor: optimize coreboot.rom for T32 flash script HACK
Attention is currently required from: Ravi kumar, Shelley Chen, Sudheer Amrabadi, Julius Werner, Yu-Ping Wu, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36278 )
Change subject: HACK trogdor: optimize coreboot.rom for T32 flash script HACK ......................................................................
Patch Set 210:
(78 comments)
File 0001-google-herobrine-configure-gpio-to-detect-board-ID.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/5ea2e3f9_b56c20b3 PS210, Line 21: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/8f3c4541_49af5bd6 PS210, Line 25: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/32dd2ba3_9fede3f1 PS210, Line 69: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/e77e3fda_cd83a7c0 PS210, Line 70: -- trailing whitespace
File 0002-mb-google-herobrine-Initialize-SPI-FW-for-EC-and-TPM.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/dd25431d_796e6752 PS210, Line 10: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/80f4ecb1_c4118879 PS210, Line 33: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/372b3a08_a90753c3 PS210, Line 38: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/199004d4_eabc04b8 PS210, Line 66: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/be544731_3cc1af0b PS210, Line 83: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/d70bca16_c06029ca PS210, Line 90: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/70c89ab5_e6bc6e06 PS210, Line 96: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/0a87bc23_4a36c128 PS210, Line 118: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/9317d6f8_1fa80e87 PS210, Line 124: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/1005f471_11085bd9 PS210, Line 146: -- trailing whitespace
File 0003-Herobrine-sc7280-Add-support-for-audio.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/848f5c73_fcb77e93 PS210, Line 9: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/a902cf2a_eeeb8057 PS210, Line 26: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/462de28a_5f8607fd PS210, Line 40: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/a1b5b069_5350f7f6 PS210, Line 51: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/c90b4881_62194f91 PS210, Line 60: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/fca0a645_ad6c5203 PS210, Line 69: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/a4e16f99_72b57cc8 PS210, Line 88: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/c72ff4ef_2985903e PS210, Line 92: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/2f28ea7c_9adc2a8d PS210, Line 94: -- trailing whitespace
File 0004-Herobrine-TPM-Config-Changes-to-support-audio.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/f16dc400_093f40ef PS210, Line 9: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/b4b61ea8_80a3df85 PS210, Line 28: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/adc86ba9_c4163270 PS210, Line 38: -- trailing whitespace
File 0005-sc7280-enable-bl31-and-SDI-feature-support.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/9495ace1_c0d65c4b PS210, Line 37: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/fc06c09c_1ed4722a PS210, Line 62: -- trailing whitespace
File 0006-sc7280-Add-Modem-region-in-memlayout-to-avoid-modem-.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/154f379e_4eb7bf25 PS210, Line 29: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/1a57b867_09b0e563 PS210, Line 41: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/0c811e95_05f9338c PS210, Line 116: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/889f23cb_51ccb2ce PS210, Line 118: -- trailing whitespace
File 0007-sc7180-Update-video-mode-active-horizontal-vertical-.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/156f6c37_85d82100 PS210, Line 25: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/48651843_bf1874ef PS210, Line 31: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/e97d4bb0_2b92c431 PS210, Line 42: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/972c221c_2d2a70c5 PS210, Line 47: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/c9dca101_c70adf80 PS210, Line 55: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/e4ac7966_695f7c1d PS210, Line 58: -- trailing whitespace
File 0008-src-mainboard-herobrine-Add-support-QUP-FW-for-I2C-a.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/5d6817fb_2e16ca66 PS210, Line 41: -- trailing whitespace
File 0009-libpayload-Parse-DDR-Information-through-coreboot-ta.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/009635ba_c842b26b PS210, Line 8: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/0339585c_ac7391b8 PS210, Line 31: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/795a114a_4b629cd4 PS210, Line 42: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/2fdabba6_fa22247d PS210, Line 106: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/8f80d43d_93fc9511 PS210, Line 108: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/965d4676_6e77667f PS210, Line 116: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/2fdb14f5_bfd48f6c PS210, Line 155: -- trailing whitespace
File 0010-src-lib-Added-CBMEM-tag-id-to-parse-ddr-information.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/ce3cda67_a93ef26a PS210, Line 7: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/c5db60d1_6e9407a6 PS210, Line 26: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/b8131d6a_5d7b2340 PS210, Line 48: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/319c15d0_5feedc7c PS210, Line 61: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/7f4a50ae_e438f719 PS210, Line 62: -- trailing whitespace
File 0011-soc-Added-dram-information-to-cbmem.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/524eced5_8e204d9c PS210, Line 7: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/0a8061c7_1420d01f PS210, Line 25: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/74f17450_654c01d6 PS210, Line 33: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/5706d4c6_4ea25943 PS210, Line 35: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/d9fd9f5b_2c889044 PS210, Line 66: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/181da72d_0fc889d4 PS210, Line 68: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/c6ada2c9_d1ab535d PS210, Line 74: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/5f25dd28_01173e4d PS210, Line 79: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/6389b2a7_035fd390 PS210, Line 87: -- trailing whitespace
File 0012-HACK-Senor-build-support-HACK.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/124f7d2b_5b263c0e PS210, Line 31: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/193789c7_840e9fbd PS210, Line 34: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/1490b516_6ca3fbca PS210, Line 42: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/6ecf6d73_4e874abe PS210, Line 43: -- trailing whitespace
File 0013-HACK-sc7280-QSIP-SPI-NOR-addressing-mode-for-SKU1-an.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/a7121495_4d7c779c PS210, Line 11: TEST=Validated on qualcomm sc7280 developement board 'developement' may be misspelled - perhaps 'development'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/22b5c228_8a0a7a52 PS210, Line 73: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/06e1ba2c_a0649546 PS210, Line 87: -- trailing whitespace
File 0014-HACK-Herobrine-Reinit-TPM-INT-GPIO.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/b5461f20_b0749658 PS210, Line 29: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/bc316df0_442a0ba1 PS210, Line 41: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/27fa7446_29c64c73 PS210, Line 47: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/59be8865_479756bc PS210, Line 60: -- trailing whitespace
File 0015-HACK-Herobrine-Reinit-TPM-INT-gpio-after-qclib-execu.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/5bb08d19_10b93a84 PS210, Line 18: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/ac6efa88_55d96e5c PS210, Line 20: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/0e5b756e_c3fd3f49 PS210, Line 32: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/9560758b_77d64fc1 PS210, Line 35: -- trailing whitespace
File 0016-HACK-herobrine-T32-scripts-working-in-standalone-env.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/d35fad7a_040e311f PS210, Line 21: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/aa8607dd_2838e96a PS210, Line 154: -- trailing whitespace
File 0017-HACK-trogdor-optimize-coreboot.rom-for-T32-flash-scr.patch:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136047): https://review.coreboot.org/c/coreboot/+/36278/comment/78503b87_53b7ca56 PS210, Line 95: -- trailing whitespace
-
build bot (Jenkins) (Code Review)