Change in coreboot[master]: vc/amd/agesa/[...]/Proc/Mem: Comment out unused function

[Name of user not set (Code Review)]

[e-mail] has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38173 )

Change subject: vc/amd/agesa/[...]/Proc/Mem: Comment out unused function
......................................................................

vc/amd/agesa/[...]/Proc/Mem: Comment out unused function

The MemNTrainingFlowNb function is not in use, but is creating a
Coverity warning. Comment it and its declaration out.

Change-Id: Ib56fb6d98f5afa0a73004c29d05647683e7a63d9
Signed-off-by: Joe Moore 
Found-by: Coverity CID 1357451
---
M src/vendorcode/amd/agesa/f14/Proc/Mem/NB/mn.c
M src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h
M src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/mn.c
M src/vendorcode/amd/agesa/f15tn/Proc/Mem/mn.h
4 files changed, 8 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/38173/1

diff --git a/src/vendorcode/amd/agesa/f14/Proc/Mem/NB/mn.c b/src/vendorcode/amd/agesa/f14/Proc/Mem/NB/mn.c
index 6afc3d0..f149d9b 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/Mem/NB/mn.c
+++ b/src/vendorcode/amd/agesa/f14/Proc/Mem/NB/mn.c
@@ -296,7 +296,7 @@
  *      The DDR3 mode bit must be set prior to calling this function
  *
  *      @param[in,out]   *NBPtr   - Pointer to the MEM_NB_BLOCK
- */
+
 BOOLEAN
 MemNTrainingFlowNb (
   IN OUT   MEM_NB_BLOCK *NBPtr
@@ -309,6 +309,7 @@
   }
   return TRUE;
 }
+*/

/*-----------------------------------------------------------------------------*/
 /**
diff --git a/src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h b/src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h
index e25c938..ec6cbc2 100644
--- a/src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h
+++ b/src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h
@@ -1023,10 +1023,12 @@
   IN OUT   MEM_NB_BLOCK *NBPtr
   );

+/*
 BOOLEAN
 MemNTrainingFlowNb (
   IN OUT   MEM_NB_BLOCK *NBPtr
   );
+*/

VOID
 MemNRecTrainingFlowNb (
diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/mn.c b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/mn.c
index 63195e0..03f05f0 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/mn.c
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/mn.c
@@ -292,7 +292,7 @@
  *      The DDR3 mode bit must be set prior to calling this function
  *
  *      @param[in,out]   *NBPtr   - Pointer to the MEM_NB_BLOCK
- */
+
 BOOLEAN
 MemNTrainingFlowNb (
   IN OUT   MEM_NB_BLOCK *NBPtr
@@ -305,6 +305,7 @@
   }
   return TRUE;
 }
+*/

/*-----------------------------------------------------------------------------*/
 /**
diff --git a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mn.h b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mn.h
index 4be78a3..b409ac5 100644
--- a/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mn.h
+++ b/src/vendorcode/amd/agesa/f15tn/Proc/Mem/mn.h
@@ -1127,10 +1127,12 @@
   IN OUT   MEM_NB_BLOCK *NBPtr
   );

+/*
 BOOLEAN
 MemNTrainingFlowNb (
   IN OUT   MEM_NB_BLOCK *NBPtr
   );
+*/

VOID
 MemNRecTrainingFlowNb (

Change in coreboot[master]: vc/amd/agesa/[...]/Config: Avoid out-of-bounds warnings

[Name of user not set (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38173

to look at the new patch set (#2).

Change subject: vc/amd/agesa/[...]/Config: Avoid out-of-bounds warnings
......................................................................

vc/amd/agesa/[...]/Config: Avoid out-of-bounds warnings

The memNTrainFlowControl array is generating Coverity warnings
in multiple places in code where it attempts to write to index 1.
The array is defined as either 2 elements or 1 of NULL depending
on #if (AGESA_ENTRY_INIT_POST == TRUE). This is likely a false
alarm from Coverity (memory should not be training outside of a
POST), but adding a second NULL element for the
AGESA_ENTRY_INIT_POST == FALSE case.

Change-Id: Ib56fb6d98f5afa0a73004c29d05647683e7a63d9
Signed-off-by: Joe Moore 
Found-by: Coverity CID 1357451, 1357452, 1357453
---
M src/vendorcode/amd/agesa/f14/Config/OptionMemoryInstall.h
M src/vendorcode/amd/agesa/f14/Proc/Mem/NB/mn.c
M src/vendorcode/amd/agesa/f14/Proc/Mem/mn.h
M src/vendorcode/amd/agesa/f15tn/Config/OptionMemoryInstall.h
M src/vendorcode/amd/agesa/f15tn/Proc/Mem/NB/mn.c
M src/vendorcode/amd/agesa/f15tn/Proc/Mem/mn.h
M src/vendorcode/amd/agesa/f16kb/Config/OptionMemoryInstall.h
7 files changed, 14 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/38173/2

Change in coreboot[master]: vc/amd/agesa/[...]/Config: Avoid out-of-bounds warnings

[Name of user not set (Code Review)]

[e-mail] has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38173 )

Change subject: vc/amd/agesa/[...]/Config: Avoid out-of-bounds warnings
......................................................................

Abandoned

Resubmitting