Attention is currently required from: Raul Rangel, Mariusz Szafrański, Jonathan Zhang, Paul Menzel, Stefan Reinauer, Kyösti Mälkki, Andrey Petrov, Patrick Rudolph, Nico Huber, Anjaneya "Reddy" Chagam, Johnny Lin, Suresh Bellampalli, Morgan Jang, Michal Motyl, Alexander Couzens, Felix Held, Shelley Chen, Furquan Shaikh, Angel Pons, Lance Zhao, Jason Glenesk, Damien Zammit, Lee Leahy, Marshall Dawson, Vanessa Eusebio, Huang Jin.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57333 )
Change subject: Rename MMCONF Kconfigs to ECAM_MMCONF
......................................................................
Patch Set 3:
(3 comments)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/57333/comment/a904178e_2a2f00a2
PS3, Line 502: NO_ECAM_MMCONF_SUPPORT
Maybe add some help text to this and the config below explaining what ECAM_MMCONF is? Basically just what you have in the commit message.
The ECAM_MMCONF support uses the Enhanced Configuration Access mechanism (ECAM)
method for accessing PCI config space. This method is specific to x86 platforms.
Other platforms, such as ARM, use a different way of mapping the PCI config
space to memory.
https://review.coreboot.org/c/coreboot/+/57333/comment/9b5c7ac0_52c87a97
PS3, Line 504: default n
default y if !x86 ?
https://review.coreboot.org/c/coreboot/+/57333/comment/8946e2ca_ff53ddcd
PS3, Line 506: ECAM_MMCONF_SUPPORT
Make this depend on X86?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57333
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1e196a1ed52d131a71f00cba1d93a23e54aca3e2
Gerrit-Change-Number: 57333
Gerrit-PatchSet: 3
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Huang Jin
huang.jin@intel.com
Gerrit-Comment-Date: Thu, 02 Sep 2021 23:59:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment