Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54669?usp=email )
Change subject: sb/amd/hudson: Skip setting up LPC decode for base < 0x20
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Which Super I/O chip driver really checks allowed boundaries specified in its datasheet? None. Each mainboard's devictree is created with an assumption that unassigned io/irq resource is just disabled resource.
- The Super I/O drivers should start checking the resources in terms of boundaries (and maybe resource existence, i.e. whether devicetree sets it)
- The PNP driver which assigns resources should also understand that zero resources are disabled resources if we don't do it in the point 1.
I had https://review.coreboot.org/c/coreboot/+/54686 implemented as a more generic solution.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54669?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idec3832d8d1ab95ae9747ce87792ee7b474540c7
Gerrit-Change-Number: 54669
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 01 Sep 2023 08:37:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment