[S] Change in coreboot[master]: mb/google/brya: enable PCIe RP12 for lisbon eMMC support - coreboot-gerrit

6 Oct 2022


      Attention is currently required from: Kevin Chiu.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68167 )
Change subject: mb/google/brya: enable PCIe RP12 for lisbon eMMC support
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/lisbon/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68167/comment/75b59da5_0628e411 
PS1, Line 205: 			register "pch_pcie_rp[PCH_RP(12)]" = "{
I think register settings need to be enclosed in a chip descriptor like lines 196-201.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68167
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief8ca9cf845156ac761556d0eb49edb65894c001
Gerrit-Change-Number: 68167
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Comment-Date: Fri, 07 Oct 2022 01:37:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment