Change in coreboot[master]: intelblocks: Add function to enable GPE - coreboot-gerrit

6 May 2022


      Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64089 )
Change subject: intelblocks: Add function to enable GPE
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/64089/comment/98adaef2_861e1f87 
PS2, Line 379: 	gpi_enable_smi(cfg, comm);
Can we "or" all the configs and set it once? In this case, we don't have to read/write many times. Put the all DW0 setting together. We can do it in the follow patch for sure.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/64089
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27e525f50c374c2cc9675e77eaa7774683a6e7c2
Gerrit-Change-Number: 64089
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Maulik V Vaghela maulik.v.vaghela@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 06 May 2022 07:15:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment