Pranava Y N has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86649?usp=email )
Change subject: mb/google/brya/nova: Enable RTD3 for SSD ......................................................................
mb/google/brya/nova: Enable RTD3 for SSD
Add PCIe RTD3 support so NVMe gets placed into D3 state when entering S0ix. Some SSDs block the CPU from reaching C10 during the S0ix suspend without the RTD3 configuration.
BUG=b:391612392 TEST=Run suspend_stress_test on nova and verify that the device suspends to S0ix.
Change-Id: Icb36285d0a12dcb098282b08ef794256af67b019 Signed-off-by: Pranava Y N pranavayn@google.com --- M src/mainboard/google/brya/variants/nova/overridetree.cb 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/86649/1
diff --git a/src/mainboard/google/brya/variants/nova/overridetree.cb b/src/mainboard/google/brya/variants/nova/overridetree.cb index c8bfc31..a615fdd 100644 --- a/src/mainboard/google/brya/variants/nova/overridetree.cb +++ b/src/mainboard/google/brya/variants/nova/overridetree.cb @@ -185,6 +185,13 @@ .clk_src = 0, .flags = PCIE_RP_LTR | PCIE_RP_AER, }" + chip soc/intel/common/block/pcie/rtd3 + register "is_storage" = "true" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_F14)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B4)" + register "srcclk_pin" = "0" + device generic 0 on end + end end device ref cnvi_wifi on chip drivers/wifi/generic