Change in coreboot[master]: Moffet: Adding CNL ISH Device ID for PCI driver.

[Bernardo Perez Priego (Code Review)]

Bernardo Perez Priego has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: Moffet: Adding CNL ISH Device ID for PCI driver.
......................................................................

Moffet: Adding CNL ISH Device ID for PCI driver.

Signed-off-by: perezpri 
Change-Id: I6d245f1b3f0d0cfec77c31033eb20f147fd3d870
---
M src/drivers/intel/ish/ish.c
M src/include/device/pci_ids.h
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/34687/1

diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c
index bc1b6fa..f506a7c 100644
--- a/src/drivers/intel/ish/ish.c
+++ b/src/drivers/intel/ish/ish.c
@@ -66,6 +66,7 @@

static const unsigned short pci_device_ids[] = {
    PCI_DEVICE_ID_INTEL_CNL_ISHB,
+	PCI_DEVICE_ID_INTEL_CML_ISHB,
    0
 };

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 1aac48e..5231841 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -2102,6 +2102,7 @@
 #define PCI_DEVICE_ID_INTEL_82437VX	0x7030
 #define PCI_DEVICE_ID_INTEL_82439TX	0x7100
 #define PCI_DEVICE_ID_INTEL_CNL_ISHB	0x9dfc
+#define PCI_DEVICE_ID_INTEL_CML_ISHB	0x02fc

/* Intel 82371FB (PIIX) */
 #define PCI_DEVICE_ID_INTEL_82371FB_ISA		0x122e

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: Moffet: Adding CNL ISH Device ID for PCI driver.
......................................................................

Patch Set 1:

(4 comments)

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@2 
PS1, Line 2: perezpri
Please use your full name.

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7 
PS1, Line 7: Moffet
Prefixes are often lowercase. What is Moffet? What is the relation to intel/ish?

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7 
PS1, Line 7: Adding
Imperative mood: Add

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7 
PS1, Line 7: Moffet: Adding CNL ISH Device ID for PCI driver.
Please remove the dot/period at the end of the commit message summary.

Change in coreboot[master]: Drallion: Adding CNL ISH Device ID for PCI driver.

[Bernardo Perez Priego (Code Review)]

Hello Thejaswani Putta, Patrick Rudolph, Selma Bensaid, John Zhao, Bora Guvendik, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34687

to look at the new patch set (#2).

Change subject: Drallion: Adding CNL ISH Device ID for PCI driver.
......................................................................

Drallion: Adding CNL ISH Device ID for PCI driver.

Change-Id: I6d245f1b3f0d0cfec77c31033eb20f147fd3d870
Signed-off-by: Bernardo Perez Priego 
---
M src/drivers/intel/ish/ish.c
M src/include/device/pci_ids.h
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/34687/2

Change in coreboot[master]: Drallion: Adding CNL ISH Device ID for PCI driver.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: Drallion: Adding CNL ISH Device ID for PCI driver.
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34687/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34687/2//COMMIT_MSG@2 
PS2, Line 2: perezpri
`git commit --amend --author="Bernardo Perez Priego "`

Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Bernardo Perez Priego (Code Review)]

Hello Thejaswani Putta, Patrick Rudolph, Selma Bensaid, John Zhao, Bora Guvendik, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34687

to look at the new patch set (#3).

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

soc/intel/cometlake: Add ISH Device ID

This is requierd to export ISH to kernel through PCI.

Change-Id: I6d245f1b3f0d0cfec77c31033eb20f147fd3d870
Signed-off-by: Bernardo Perez Priego 
---
M src/drivers/intel/ish/ish.c
M src/include/device/pci_ids.h
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/34687/3

Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Li1 Feng (Code Review)]

Li1 Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34687/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34687/3//COMMIT_MSG@9 
PS3, Line 9: export ISH
this is only for CML ISH, could you specify that?

Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Bernardo Perez Priego (Code Review)]

Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

Patch Set 3:

(4 comments)

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@2 
PS1, Line 2: perezpri
> Please use your full name.

Ack

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7 
PS1, Line 7: Moffet: Adding CNL ISH Device ID for PCI driver.
> Please remove the dot/period at the end of the commit message summary.

Ack

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7 
PS1, Line 7: Moffet
> Prefixes are often lowercase. […]

Using SOC name instead.

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7 
PS1, Line 7: Adding
> Imperative mood: Add

Ack

Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Bernardo Perez Priego (Code Review)]

Hello Thejaswani Putta, Patrick Rudolph, Kyoung Il Kim, Li1 Feng, Selma Bensaid, John Zhao, Bora Guvendik, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34687

to look at the new patch set (#4).

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

soc/intel/cometlake: Add ISH Device ID

This Device ID is specific to CML, since it is  obtained by reading ISH
configuration RO register.
In order to export ISH to kernel PCI device tree, this number must be
included in list of devies supported.

Change-Id: I6d245f1b3f0d0cfec77c31033eb20f147fd3d870
Signed-off-by: Bernardo Perez Priego 
---
M src/drivers/intel/ish/ish.c
M src/include/device/pci_ids.h
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/34687/4

Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Bernardo Perez Priego (Code Review)]

Hello Thejaswani Putta, Patrick Rudolph, Kyoung Il Kim, Li1 Feng, Selma Bensaid, John Zhao, Bora Guvendik, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/34687

to look at the new patch set (#5).

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

soc/intel/cometlake: Add ISH Device ID

This Device ID is specific to CML, since it is obtained by reading ISH
configuration RO register.
In order to export ISH to kernel PCI device tree, this number must be
included in list of devices supported.

Change-Id: I6d245f1b3f0d0cfec77c31033eb20f147fd3d870
Signed-off-by: Bernardo Perez Priego 
---
M src/drivers/intel/ish/ish.c
M src/include/device/pci_ids.h
2 files changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/34687/5

Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Bernardo Perez Priego (Code Review)]

Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34687/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34687/3//COMMIT_MSG@9 
PS3, Line 9: export ISH
> this is only for CML ISH, could you specify that?

Ack

Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Li1 Feng (Code Review)]

Li1 Feng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

Patch Set 5: Code-Review+1

Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Mathew King (Code Review)]

Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

Patch Set 5: Code-Review+2

Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

Patch Set 5:

(2 comments)

In the future, please make sure that all of your comments are marked as resolved so the patch can be committed.

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34687/1//COMMIT_MSG@7 
PS1, Line 7: Moffet
> Using SOC name instead.

Done

https://review.coreboot.org/c/coreboot/+/34687/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34687/2//COMMIT_MSG@2 
PS2, Line 2: perezpri
> `git commit --amend --author="Bernardo Perez Priego <bernardo.perez.priego@intel. […]

Done

Change in coreboot[master]: soc/intel/cometlake: Add ISH Device ID

[Martin Roth (Code Review)]

Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34687 )

Change subject: soc/intel/cometlake: Add ISH Device ID
......................................................................

soc/intel/cometlake: Add ISH Device ID

This Device ID is specific to CML, since it is obtained by reading ISH
configuration RO register.
In order to export ISH to kernel PCI device tree, this number must be
included in list of devices supported.

Change-Id: I6d245f1b3f0d0cfec77c31033eb20f147fd3d870
Signed-off-by: Bernardo Perez Priego 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34687
Reviewed-by: Li1 Feng 
Reviewed-by: Mathew King 
Tested-by: build bot (Jenkins) 
---
M src/drivers/intel/ish/ish.c
M src/include/device/pci_ids.h
2 files changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Li1 Feng: Looks good to me, but someone else must approve
  Mathew King: Looks good to me, approved

diff --git a/src/drivers/intel/ish/ish.c b/src/drivers/intel/ish/ish.c
index bc1b6fa..f506a7c 100644
--- a/src/drivers/intel/ish/ish.c
+++ b/src/drivers/intel/ish/ish.c
@@ -66,6 +66,7 @@

static const unsigned short pci_device_ids[] = {
    PCI_DEVICE_ID_INTEL_CNL_ISHB,
+	PCI_DEVICE_ID_INTEL_CML_ISHB,
    0
 };

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 3ac6560..2501640 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -2102,6 +2102,7 @@
 #define PCI_DEVICE_ID_INTEL_82437VX	0x7030
 #define PCI_DEVICE_ID_INTEL_82439TX	0x7100
 #define PCI_DEVICE_ID_INTEL_CNL_ISHB	0x9dfc
+#define PCI_DEVICE_ID_INTEL_CML_ISHB	0x02fc

/* Intel 82371FB (PIIX) */
 #define PCI_DEVICE_ID_INTEL_82371FB_ISA		0x122e