Attention is currently required from: Patrick Rudolph.
Hello Felix Held, Krystian Hebel, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78192?usp=email
to look at the new patch set (#2).
Change subject: x86/include/arch/cpuid.h: Fix inline assembly ......................................................................
x86/include/arch/cpuid.h: Fix inline assembly
In the cpuid helper functions eax is always written to by the cpuid instruction, so add it to the output clobbered list.
This prevents GCC from generating code with undefined behaviour when the function is inlined.
Test: Verified that the generated assembly is sane and runtime tests showed no "strange" behaviour when calling cpuid functions.
Change-Id: I5dc0bb620184a355716b9c8d4206d55554b41ab9 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/arch/x86/include/arch/cpuid.h 1 file changed, 9 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/78192/2