Attention is currently required from: Bao Zheng, Zheng Bao.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69856 )
Change subject: WIP:amdfwtool: Allow the location to be a relative address ......................................................................
Patch Set 5:
(6 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167619): https://review.coreboot.org/c/coreboot/+/69856/comment/c5a30719_53352bec PS5, Line 2475: case 0xFA0000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167619): https://review.coreboot.org/c/coreboot/+/69856/comment/fde91308_f603c862 PS5, Line 2476: case 0xF20000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167619): https://review.coreboot.org/c/coreboot/+/69856/comment/6ff9b88f_d118b121 PS5, Line 2477: case 0xE20000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167619): https://review.coreboot.org/c/coreboot/+/69856/comment/3ee50c25_8ab87f06 PS5, Line 2478: case 0xC20000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167619): https://review.coreboot.org/c/coreboot/+/69856/comment/201b2f79_97135770 PS5, Line 2479: case 0x820000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167619): https://review.coreboot.org/c/coreboot/+/69856/comment/4eefd6e7_e5be48d1 PS5, Line 2480: case 0x020000: /* Fallthrough */ Prefer 'fallthrough;' over fallthrough comment