Change in coreboot[master]: [WIP]mb/intel/tglrvp: Set gpio GPP_H1

[Shaunak Saha (Code Review)]

Shaunak Saha has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: [WIP]mb/intel/tglrvp: Set gpio GPP_H1
......................................................................

[WIP]mb/intel/tglrvp: Set gpio GPP_H1

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully.

Change-Id: Ic0ef33079af7940360c986efacabd6d367aad516
Signed-off-by: Shaunak Saha 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/41811/1

diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
index 4457506..6a33dcf 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
@@ -54,6 +54,8 @@
    /* CNVi */
    PAD_CFG_NF(GPP_F4, NONE, DEEP, NF1),  /* CNV_RF_RST_L */
    PAD_CFG_NF(GPP_F5, NONE, DEEP, NF3),  /* CNV_CLKREQ0 */
+
+	PAD_CFG_GPO(GPP_H1, 1, DEEP),
 };

/* Early pad configuration in bootblock */

[Shaunak Saha (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41811

to look at the new patch set (#2).

Change subject: [WIP]mb/intel/tglrvp: Set gpio GPP_H1
......................................................................

[WIP]mb/intel/tglrvp: Set gpio GPP_H1

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully.

Change-Id: Ic0ef33079af7940360c986efacabd6d367aad516
Signed-off-by: Shaunak Saha 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
2 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/41811/2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: [WIP]mb/intel/tglrvp: Set gpio GPP_H1
......................................................................

Patch Set 2:

(1 comment)

I see, it’s still WIP, so I assume the commit message will be expanded.

https://review.coreboot.org/c/coreboot/+/41811/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41811/2//COMMIT_MSG@7 
PS2, Line 7: [WIP]mb/intel/tglrvp: Set gpio GPP_H1
> Set GPIO GPP_H1 to …

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1

[Shaunak Saha (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41811

to look at the new patch set (#3).

Change subject: mb/intel/tglrvp: Set gpio GPP_H1
......................................................................

mb/intel/tglrvp: Set gpio GPP_H1

This patch sets the GPP_H1. We need this GPIO for the
detection of soundcard in TGL RVP's.

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully. From "aplay -l"
output check that soundcards are listed properly.

Change-Id: Ic0ef33079af7940360c986efacabd6d367aad516
Signed-off-by: Shaunak Saha 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
2 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/41811/3

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Shaunak Saha (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41811

to look at the new patch set (#4).

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

This patch sets the GPP_H1 to PAD_CFG_GPO which is general
purpose output with no pullup/down. We need this GPIO for
the detection of soundcard in TGL RVP's.

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully. From "aplay -l"
output check that soundcards are listed properly.

Change-Id: Ic0ef33079af7940360c986efacabd6d367aad516
Signed-off-by: Shaunak Saha 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
2 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/41811/4

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41811/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41811/2//COMMIT_MSG@7 
PS2, Line 7: [WIP]mb/intel/tglrvp: Set gpio GPP_H1
> > Set GPIO GPP_H1 to …

Done

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 4: Code-Review+1

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Sathyanarayana Nujella (Code Review)]

Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Shreesh Chhabbi (Code Review)]

Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 4: Code-Review+1

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41811/4/src/mainboard/intel/tglrvp/... 
File src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c:

https://review.coreboot.org/c/coreboot/+/41811/4/src/mainboard/intel/tglrvp/... 
PS4, Line 59: };
please add a comment indicating signal name or function.

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Shaunak Saha (Code Review)]

Hello Sathyanarayana Nujella, build bot (Jenkins), Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Shreesh Chhabbi, Duncan Laurie, Shreesh Chhabbi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41811

to look at the new patch set (#5).

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

This patch sets the GPP_H1 to PAD_CFG_GPO which is general
purpose output with no pullup/down. We need this GPIO for
the detection of soundcard in TGL RVP's.

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully. From "aplay -l"
output check that soundcards are listed properly.

Change-Id: Ic0ef33079af7940360c986efacabd6d367aad516
Signed-off-by: Shaunak Saha 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
2 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/41811/5

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41811/4/src/mainboard/intel/tglrvp/... 
File src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c:

https://review.coreboot.org/c/coreboot/+/41811/4/src/mainboard/intel/tglrvp/... 
PS4, Line 59: };
> please add a comment indicating signal name or function.

Done

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 5: Code-Review+2

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Sathyanarayana Nujella (Code Review)]

Sathyanarayana Nujella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 5: Code-Review+1

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 5: Code-Review+1

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Wonkyu Kim (Code Review)]

Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 5: Code-Review+2

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for souncard detection
......................................................................

Patch Set 5: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/41811/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41811/5//COMMIT_MSG@7 
PS5, Line 7: souncard
soun*d*card

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection

[Shaunak Saha (Code Review)]

Hello Sathyanarayana Nujella, build bot (Jenkins), Patrick Georgi, Furquan Shaikh, Wonkyu Kim, Caveh Jalali, Shreesh Chhabbi, Duncan Laurie, Angel Pons, Shreesh Chhabbi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41811

to look at the new patch set (#6).

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection
......................................................................

mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection

This patch sets the GPP_H1 to PAD_CFG_GPO which is general
purpose output with no pullup/down. We need this GPIO for
the detection of soundcard in TGL RVP's.

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully. From "aplay -l"
output check that soundcards are listed properly.

Change-Id: Ic0ef33079af7940360c986efacabd6d367aad516
Signed-off-by: Shaunak Saha 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
2 files changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/41811/6

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection

[Shaunak Saha (Code Review)]

Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection
......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41811/5//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41811/5//COMMIT_MSG@7 
PS5, Line 7: souncard
> soun*d*card

Done

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection

[Selma Bensaid (Code Review)]

Selma Bensaid has uploaded a new patch set (#7) to the change originally created by Shaunak Saha. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection
......................................................................

mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection

This patch sets the GPP_H1 to PAD_CFG_GPO which is general
purpose output with no pullup/down. We need this GPIO for
the detection of soundcard in TGL RVP's.

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully. From "aplay -l"
output check that soundcards are listed properly.

Change-Id: Ic0ef33079af7940360c986efacabd6d367aad516
Signed-off-by: Shaunak Saha 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
2 files changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/41811/7

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection

[Selma Bensaid (Code Review)]

Selma Bensaid has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection
......................................................................

Patch Set 7:

patch rebased.

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection

[Nick Vaccaro (Code Review)]

Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection
......................................................................

Patch Set 7: Code-Review+2

Change in coreboot[master]: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection

[Nick Vaccaro (Code Review)]

Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41811 )

Change subject: mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection
......................................................................

mb/intel/tglrvp: Set gpio GPP_H1 for soundcard detection

This patch sets the GPP_H1 to PAD_CFG_GPO which is general
purpose output with no pullup/down. We need this GPIO for
the detection of soundcard in TGL RVP's.

BUG=none
BRANCH=none
TEST=Build and boot tglrvp successfully. From "aplay -l"
output check that soundcards are listed properly.

Change-Id: Ic0ef33079af7940360c986efacabd6d367aad516
Signed-off-by: Shaunak Saha 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41811
Tested-by: build bot (Jenkins) 
Reviewed-by: Nick Vaccaro 
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nick Vaccaro: Looks good to me, approved

diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
index 398a185..49946c8 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/gpio.c
@@ -57,6 +57,8 @@

/* EC_SYNC_IRQ */
    PAD_CFG_GPI_APIC(GPP_A15, NONE, PLTRST, LEVEL, INVERT), /* MECC_HPD2 */
+
+	PAD_CFG_GPO(GPP_H1, 1, DEEP), /* AUDIO_PWREN */
 };

/* Early pad configuration in bootblock */
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
index 6c94a1c..91bbe93 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/gpio.c
@@ -53,6 +53,8 @@

/* EC_SYNC_IRQ */
    PAD_CFG_GPI_APIC(GPP_A15, NONE, PLTRST, LEVEL, INVERT), /* MECC_HPD2 */
+
+	PAD_CFG_GPO(GPP_H1, 1, DEEP), /* AUDIO_PWREN */
 };

/* Early pad configuration in bootblock */