Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43924 )
Change subject: mb/intel/cedarisland: Remove duplicated code ......................................................................
mb/intel/cedarisland: Remove duplicated code
Some UPD options are already set in `xeon_sp/cpx/romstage.c`. Remove them from the board configuration to avoid duplicating this code.
Change-Id: Ic79245103c33427e06c7ea881be778e3d219c45f Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43924 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/intel/cedarisland_crb/romstage.c 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/intel/cedarisland_crb/romstage.c b/src/mainboard/intel/cedarisland_crb/romstage.c index 8468605..03e28a1 100644 --- a/src/mainboard/intel/cedarisland_crb/romstage.c +++ b/src/mainboard/intel/cedarisland_crb/romstage.c @@ -6,9 +6,5 @@ { FSP_M_CONFIG *m_cfg = &mupd->FspmConfig;
- m_cfg->BoardId = 0x1d; - m_cfg->BoardTypeBitmask = 0x11111111; - m_cfg->DebugPrintLevel = 8; m_cfg->KtiLinkSpeedMode = 0; - m_cfg->KtiPrefetchEn = 2; }