HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43966 )
Change subject: src/console: Add missing <{stddef,stdint}.h> ......................................................................
src/console: Add missing <{stddef,stdint}.h>
Change-Id: Ie8fe8d6c70b396498156767ae0c5b8567adf1b07 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/console/console.c M src/console/vsprintf.c M src/console/vtxprintf.c 3 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/43966/1
diff --git a/src/console/console.c b/src/console/console.c index bc9d918..3f170dc 100644 --- a/src/console/console.c +++ b/src/console/console.c @@ -9,6 +9,8 @@ #include <console/usb.h> #include <console/spi.h> #include <console/flash.h> +#include <stddef.h> +#include <stdint.h>
void console_hw_init(void) { diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index d0c569b..f1d9dca 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <console/vtxprintf.h> +#include <stddef.h> #include <string.h> #include <trace.h>
diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c index 273bc7e..2dd10d0 100644 --- a/src/console/vtxprintf.c +++ b/src/console/vtxprintf.c @@ -6,6 +6,7 @@
#include <console/vtxprintf.h> #include <ctype.h> +#include <stddef.h> #include <string.h> #include <stdint.h>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43966 )
Change subject: src/console: Add missing <{stddef,stdint}.h> ......................................................................
Patch Set 1:
(4 comments)
I've added comments to make the review easy.
https://review.coreboot.org/c/coreboot/+/43966/1/src/console/console.c File src/console/console.c:
https://review.coreboot.org/c/coreboot/+/43966/1/src/console/console.c@57 PS1, Line 57: uint8_t stdint
https://review.coreboot.org/c/coreboot/+/43966/1/src/console/console.c@57 PS1, Line 57: size_t stddef
https://review.coreboot.org/c/coreboot/+/43966/1/src/console/vsprintf.c File src/console/vsprintf.c:
https://review.coreboot.org/c/coreboot/+/43966/1/src/console/vsprintf.c@10 PS1, Line 10: size_t stddef
https://review.coreboot.org/c/coreboot/+/43966/1/src/console/vtxprintf.c File src/console/vtxprintf.c:
https://review.coreboot.org/c/coreboot/+/43966/1/src/console/vtxprintf.c@202 PS1, Line 202: size_t stddef
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43966 )
Change subject: src/console: Add missing <{stddef,stdint}.h> ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review)