HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46007 )
Change subject: mb/asus/p5gc-mx: Convert *.asl to ASL 2.0 syntax ......................................................................
mb/asus/p5gc-mx: Convert *.asl to ASL 2.0 syntax
Change-Id: I38bab3a77244a588df123a1c84412fd019e61988 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p5gc-mx/acpi/ec.asl M src/mainboard/asus/p5gc-mx/acpi/superio.asl 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/46007/1
diff --git a/src/mainboard/asus/p5gc-mx/acpi/ec.asl b/src/mainboard/asus/p5gc-mx/acpi/ec.asl index 2997587..e69de29 100644 --- a/src/mainboard/asus/p5gc-mx/acpi/ec.asl +++ b/src/mainboard/asus/p5gc-mx/acpi/ec.asl @@ -1 +0,0 @@ -/* dummy */ diff --git a/src/mainboard/asus/p5gc-mx/acpi/superio.asl b/src/mainboard/asus/p5gc-mx/acpi/superio.asl index 2997587..e69de29 100644 --- a/src/mainboard/asus/p5gc-mx/acpi/superio.asl +++ b/src/mainboard/asus/p5gc-mx/acpi/superio.asl @@ -1 +0,0 @@ -/* dummy */
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46007 )
Change subject: mb/asus/p5gc-mx: Convert *.asl to ASL 2.0 syntax ......................................................................
Patch Set 1: Code-Review-1
How is removing a comment equal to converting to ASL 2.0 syntax?
Hello build bot (Jenkins), Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46007
to look at the new patch set (#2).
Change subject: mb/asus/p5gc-mx: Remove useless comments ......................................................................
mb/asus/p5gc-mx: Remove useless comments
Change-Id: I38bab3a77244a588df123a1c84412fd019e61988 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/p5gc-mx/acpi/ec.asl M src/mainboard/asus/p5gc-mx/acpi/superio.asl 2 files changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/46007/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46007 )
Change subject: mb/asus/p5gc-mx: Remove useless comments ......................................................................
Patch Set 2:
Patch Set 1: Code-Review-1
How is removing a comment equal to converting to ASL 2.0 syntax?
Oops. Thx
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46007 )
Change subject: mb/asus/p5gc-mx: Remove useless comments ......................................................................
Abandoned
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46007 )
Change subject: mb/asus/p5gc-mx: Remove useless comments ......................................................................
Patch Set 2:
please see https://review.coreboot.org/c/coreboot/+/46122
-
Arthur Heymans (Code Review) -
HAOUAS Elyes (Code Review)