Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37892 )
Change subject: mb/google/samus: Fix touchscreen wake GPIO ......................................................................
mb/google/samus: Fix touchscreen wake GPIO
Wrong macro was copy/pasted at some point
Change-Id: I92826cbac599c50ce7f7c5dabde066367edc3053 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/auron/variants/samus/include/variant/acpi/mainboard.asl 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/37892/1
diff --git a/src/mainboard/google/auron/variants/samus/include/variant/acpi/mainboard.asl b/src/mainboard/google/auron/variants/samus/include/variant/acpi/mainboard.asl index 40a4df0..802e827 100644 --- a/src/mainboard/google/auron/variants/samus/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/auron/variants/samus/include/variant/acpi/mainboard.asl @@ -201,7 +201,7 @@
Method (_DSW, 3, NotSerialized) { - Store (BOARD_CODEC_WAKE_GPIO, Local0) + Store (BOARD_TOUCHSCREEN_WAKE_GPIO, Local0) If (LEqual (Arg0, 1)) { // Enable GPIO as wake source _SB.PCI0.LPCB.GPIO.GWAK (Local0)
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37892 )
Change subject: mb/google/samus: Fix touchscreen wake GPIO ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37892/1/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/samus/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/37892/1/src/mainboard/google/auron/... PS1, Line 16: #undef ENABLE_TOUCH_WAKE Isn't the code below dead anyway?
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37892 )
Change subject: mb/google/samus: Fix touchscreen wake GPIO ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37892/1/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/samus/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/37892/1/src/mainboard/google/auron/... PS1, Line 16: #undef ENABLE_TOUCH_WAKE
Isn't the code below dead anyway?
heh, sure looks that way
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37892 )
Change subject: mb/google/samus: Fix touchscreen wake GPIO ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37892/1/src/mainboard/google/auron/... File src/mainboard/google/auron/variants/samus/include/variant/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/37892/1/src/mainboard/google/auron/... PS1, Line 16: #undef ENABLE_TOUCH_WAKE
heh, sure looks that way
so looking at the Chromium source, both touchpad/touchscreen were disabled during development due to a touchpad wake issue, and only the touchpad was re-enabled. Guess we'd need to test to determine if the touchscreen can be re-enabled as a wake source without issue
Matt DeVillier has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37892 )
Change subject: mb/google/samus: Fix touchscreen wake GPIO ......................................................................
Abandoned
-
Matt DeVillier (Code Review) -
Nico Huber (Code Review)