Ivan Labáth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39087 )
Change subject: util/lint: Permit capitalized coreboot at start of sentence ......................................................................
util/lint: Permit capitalized coreboot at start of sentence
It seems preferred spelling for coreboot is lowercase. On the other hand, it seems proper to capitalize coreboot at start of sentence, especially in proper text.
This patch permits coreboot to be capitalized at start of sentence, line or after colon. Line and colon is mostly due to how grepping works.
Test: Coreboot Test. Coreboot Coreboot
Not permitted - coreboot, coreboot. coreboot (double space).
Change-Id: I344e52262956ba45c3abcd1e878284ba338353f1 Signed-off-by: Ivan Labáth iger@labo.rs --- M util/lint/lint-stable-021-coreboot-lowercase 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39087/1
diff --git a/util/lint/lint-stable-021-coreboot-lowercase b/util/lint/lint-stable-021-coreboot-lowercase index a71d204..b3787e0 100755 --- a/util/lint/lint-stable-021-coreboot-lowercase +++ b/util/lint/lint-stable-021-coreboot-lowercase @@ -16,7 +16,7 @@
LC_ALL=C export LC_ALL
-EXCLUDE='^3rdparty/|util/crossgcc/xgcc|Binary file|coreboot|COREBOOT|CorebootPayload|CorebootModule|minnowboard.org/Coreboot|.*.patch$|CorebootBdsLib|^payloads/external' +EXCLUDE='^3rdparty/|util/crossgcc/xgcc|Binary file|coreboot|COREBOOT|. Coreboot|(^|:) *Coreboot|CorebootPayload|CorebootModule|minnowboard.org/Coreboot|.*.patch$|CorebootBdsLib|^payloads/external'
# Use git grep if the code is in a git repo, otherwise use grep. if [ -n "$(command -v git)" ] && \
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39087 )
Change subject: util/lint: Permit capitalized coreboot at start of sentence ......................................................................
Patch Set 1: Code-Review-1
The 'c' in coreboot is intended to be lowercase to match its trademark (https://trademarks.justia.com/869/60/coreboot-86960637.html).
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39087 )
Change subject: util/lint: Permit capitalized coreboot at start of sentence ......................................................................
Patch Set 1: Code-Review-1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39087 )
Change subject: util/lint: Permit capitalized coreboot at start of sentence ......................................................................
Patch Set 1: Code-Review-1
(2 comments)
I don't think this is a good idea.
https://review.coreboot.org/c/coreboot/+/39087/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39087/1//COMMIT_MSG@10 PS1, Line 10: it seems proper To whom?
https://review.coreboot.org/c/coreboot/+/39087/1//COMMIT_MSG@11 PS1, Line 11: proper text What is "proper text"? Conversely, what would "improper text" be?
Ivan Labáth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39087 )
Change subject: util/lint: Permit capitalized coreboot at start of sentence ......................................................................
Patch Set 1:
(2 comments)
Patch Set 1: Code-Review-1
(2 comments)
I don't think this is a good idea.
Thank you for the review. I hope I have answered the questions.and will happily answer any others.
That being said, a single sentence doesn't seem particularly important, hence I withdraw my change request.
https://review.coreboot.org/c/coreboot/+/39087/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39087/1//COMMIT_MSG@10 PS1, Line 10: it seems proper
To whom?
I would think a lot of people. See capitalization rules[1][2][3][4], point 1, as found by a random search. Point 11 of [2] even states trademarks should be capitalized.
There seems to be disagreement as to when exceptions are permitted[4][5][6]. Listed examples are name of an author that didn't capitalize anything, mixed-case names (iThing), and names (variables, functions ..) where capitalization would be a meaningful change, neither of which seem directly relevant.
[1] https://www.grammarly.com/blog/capitalization-rules/ [2] https://webapps.towson.edu/ows/capitalization_rules.htm [3] https://grammar.yourdictionary.com/capitalization/10-rules-of-capitalization... [4] https://www.thefreedictionary.com/Rules-for-Capitalization.htm [5] https://blog.apastyle.org/apastyle/2013/11/is-it-sometimes-okay-to-begin-a-s... [6] https://english.stackexchange.com/questions/68660/can-a-sentence-start-with-...
https://review.coreboot.org/c/coreboot/+/39087/1//COMMIT_MSG@11 PS1, Line 11: proper text
What is "proper text"? Conversely, what would "improper text" be?
I meant terse fragments or comments vs. flowing text with structure, sentences, paragraphs, that one would expect to abide by the grammar rules of a given language.
Ivan Labáth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39087 )
Change subject: util/lint: Permit capitalized coreboot at start of sentence ......................................................................
Abandoned
avoid bikeshedding
-
Angel Pons (Code Review) -
David Hendricks (Code Review)
-
HAOUAS Elyes (Code Review)
-
Ivan Labáth (Code Review)