Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43651 )
Change subject: mb/system76/lemp9: gpio: add a pull-down for MODEM_CLKREQ / CNVI_CLKREQ ......................................................................
mb/system76/lemp9: gpio: add a pull-down for MODEM_CLKREQ / CNVI_CLKREQ
MODEM_CLKREQ / CNVI_CLKREQ has no external pull-down resistor. When there is no M.2 card populated, the pin is floating. Thus enable an internal 20K PD.
Signed-off-by: Michael Niewöhner foss@mniewoehner.de Change-Id: I37e0a9d7e9e0a8c8a7ac198abfd3995b8b0f9e3e Reviewed-on: https://review.coreboot.org/c/coreboot/+/43651 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/system76/lemp9/gpio.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved
diff --git a/src/mainboard/system76/lemp9/gpio.h b/src/mainboard/system76/lemp9/gpio.h index 645cdfd..9c99f13 100644 --- a/src/mainboard/system76/lemp9/gpio.h +++ b/src/mainboard/system76/lemp9/gpio.h @@ -467,7 +467,7 @@ // CNV_RF_RESET# / CNVI_RST# PAD_CFG_NF(GPP_H1, NONE, DEEP, NF3), // MODEM_CLKREQ / CNVI_CLKREQ - PAD_CFG_NF(GPP_H2, NONE, DEEP, NF3), + PAD_CFG_NF(GPP_H2, DN_20K, DEEP, NF3), // NC PAD_NC(GPP_H3, UP_20K),