Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29415 )
Change subject: src/soc/intel/braswell/southcluster.c: Config ISA DMA controller ......................................................................
src/soc/intel/braswell/southcluster.c: Config ISA DMA controller
ISA dma controller is not configured. Add call isa_dma_init().
BUG=N/A TEST=Intel CherryHill CRB
Change-Id: Ib7af3f4ef6d6a29628bb2c27d32071be63ff6af2 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/29415 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/soc/intel/braswell/southcluster.c 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Michał Żygowski: Looks good to me, approved
diff --git a/src/soc/intel/braswell/southcluster.c b/src/soc/intel/braswell/southcluster.c index 418035f..dc918eb 100644 --- a/src/soc/intel/braswell/southcluster.c +++ b/src/soc/intel/braswell/southcluster.c @@ -26,6 +26,7 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ids.h> +#include <pc80/isa-dma.h> #include <pc80/i8254.h> #include <pc80/i8259.h> #include <romstage_handoff.h> @@ -268,6 +269,8 @@ printk(BIOS_SPEW, "%s/%s (%s)\n", __FILE__, __func__, dev_name(dev));
+ isa_dma_init(); + /* Set up the PIRQ PIC routing based on static config. */ for (i = 0; i < NUM_PIRQS; i++) write8((void *)(pr_base + i*sizeof(ir->pic[i])),