[S] Change in coreboot[master]: mb/google/myst: Add FW_CONFIG - coreboot-gerrit

6 Apr 2023


      Attention is currently required from: Raul Rangel, Jon Murphy, Karthik Ramasubramanian, Mark Hasemeyer.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74102 )
Change subject: mb/google/myst: Add FW_CONFIG
......................................................................
Patch Set 21: Code-Review+1
(1 comment)
File src/mainboard/google/myst/variants/myst/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74102/comment/3e8fa63c_5c34fc6c 
PS4, Line 20:
...
I don't believe so. […]
So we don't need that to disable PCI or EMMC bus. Or some gpio need to update based on storage type. Is that right? Because on Intel project that would be slightly different.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74102
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If74c3649d4e8d174d9fe00a4b896c2351ee3ab19
Gerrit-Change-Number: 74102
Gerrit-PatchSet: 21
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Jon Murphy jpmurphy@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Mark Hasemeyer markhas@google.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 01:47:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jon Murphy jpmurphy@google.com
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment