Ren Kuo has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30909
Change subject: mb/google/poppy/variants/nami: correct the spd of hynix dimm ......................................................................
mb/google/poppy/variants/nami: correct the spd of hynix dimm
Correct the P/N of spd data for hynix_dimm_H5AN8G6NCJR-VKC BUG=b:122813741 TEST=emerge-nami coreboot chromeos-bootimage check the memeory data on DUT
Change-Id: Ia0f857a072efe60e9569214f4b639d8becf3a7e4 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/30909/1
diff --git a/src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex b/src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex index 5050647..060871d 100644 --- a/src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex +++ b/src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex @@ -18,8 +18,8 @@ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -80 AD 01 00 00 00 00 00 00 48 4D 41 38 35 31 53 -36 43 4A 52 36 4E 2D 56 4B 20 20 20 20 00 80 AD +80 AD 01 00 00 00 00 00 00 48 35 41 38 47 36 4E +43 4A 52 2D 56 4B 43 20 20 20 20 20 20 00 80 AD FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30909
to look at the new patch set (#2).
Change subject: mb/google/poppy/variants/nami: correct the spd of hynix dimm ......................................................................
mb/google/poppy/variants/nami: correct the spd of hynix dimm
Correct the P/N of spd data for hynix_dimm_H5AN8G6NCJR-VKC BUG=b:122813741 TEST=emerge-nami coreboot chromeos-bootimage check the memeory data on DUT
Change-Id: Ia0f857a072efe60e9569214f4b639d8becf3a7e4 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/30909/2
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30909 )
Change subject: mb/google/poppy/variants/nami: correct the spd of hynix dimm ......................................................................
Patch Set 2: Code-Review+1
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30909 )
Change subject: mb/google/poppy/variants/nami: correct the spd of hynix dimm ......................................................................
Patch Set 2: Code-Review-1
Hello Shelley Chen, build bot (Jenkins), Martin Roth, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30909
to look at the new patch set (#3).
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
mb/google/poppy/variants/nami: correct the spd data of memory parts
Correct the P/N of spd data for the memoery parts: hynix_dimm_H5AN8G6NCJR-VKC micron_dimm_MT40A512M16LY-075E micron_dimm_MT40A256M16GE-083E samsung_dimm_K4A8G165WB-BCRC
BUG=b:122813741 TEST=emerge-nami coreboot chromeos-bootimage check the spd data on DUT
Change-Id: Ia0f857a072efe60e9569214f4b639d8becf3a7e4 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex M src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16GE-083E.spd.hex M src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16LY-075E.spd.hex M src/mainboard/google/poppy/spd/samsung_dimm_K4A4G165WE-BCRC.spd.hex 4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/30909/3
Hello Shelley Chen, build bot (Jenkins), Martin Roth, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30909
to look at the new patch set (#4).
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
mb/google/poppy/variants/nami: correct the spd data of memory parts
Correct the P/N of spd data for the memoery parts: hynix_dimm_H5AN8G6NCJR-VKC micron_dimm_MT40A512M16LY-075E micron_dimm_MT40A256M16GE-083E samsung_dimm_K4A8G165WE-BCRC
BUG=b:122813741 TEST=emerge-nami coreboot chromeos-bootimage check the spd data on DUT
Change-Id: Ia0f857a072efe60e9569214f4b639d8becf3a7e4 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex M src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16GE-083E.spd.hex M src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16LY-075E.spd.hex M src/mainboard/google/poppy/spd/samsung_dimm_K4A4G165WE-BCRC.spd.hex 4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/30909/4
Hello Shelley Chen, build bot (Jenkins), Martin Roth, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30909
to look at the new patch set (#5).
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
mb/google/poppy/variants/nami: correct the spd data of memory parts
Correct the P/N of spd data for the memoery parts: hynix_dimm_H5AN8G6NCJR-VKC micron_dimm_MT40A512M16LY-075E micron_dimm_MT40A256M16GE-083E samsung_dimm_K4A8G165WE-BCRC
BUG=b:122813741 TEST=emerge-nami coreboot chromeos-bootimage check the spd data on DUT
Change-Id: Ia0f857a072efe60e9569214f4b639d8becf3a7e4 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex M src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16GE-083E.spd.hex M src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16LY-075E.spd.hex M src/mainboard/google/poppy/spd/samsung_dimm_K4A4G165WE-BCRC.spd.hex 4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/30909/5
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30909 )
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
Patch Set 5: Code-Review+1
Vincent Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30909 )
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
Patch Set 5: Code-Review+1
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30909 )
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/30909/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30909/1//COMMIT_MSG@12 PS1, Line 12: memeory memory
https://review.coreboot.org/#/c/30909/1//COMMIT_MSG@13 PS1, Line 13: Was the memory part not booting before and now it's booting with this change?
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30909 )
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
Patch Set 5:
Martin (Roth) just let me know that this change could cause mosys errors in released nami devices when reading the SPD part because mosys only reads from the RO partition. So, this could cause mosys issues in devices like sona/vayne/pantheon/akali.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30909 )
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
Patch Set 5:
Here's the bug for this: https://buganizer.corp.google.com/issues/122986052
Hello Vincent Wang, Shelley Chen, build bot (Jenkins), Patrick Georgi, Martin Roth, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/30909
to look at the new patch set (#6).
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
mb/google/poppy/variants/nami: correct the spd data of memory parts
Correct the P/N of spd data for the memory parts: hynix_dimm_H5AN8G6NCJR-VKC micron_dimm_MT40A512M16LY-075E micron_dimm_MT40A256M16GE-083E samsung_dimm_K4A8G165WE-BCRC
BUG=b:122813741 TEST=emerge-nami coreboot chromeos-bootimage check the spd data on DUT
Change-Id: Ia0f857a072efe60e9569214f4b639d8becf3a7e4 Signed-off-by: Ren Kuo ren.kuo@quanta.corp-partner.google.com --- M src/mainboard/google/poppy/spd/hynix_dimm_H5AN8G6NCJR-VKC.spd.hex M src/mainboard/google/poppy/spd/micron_dimm_MT40A256M16GE-083E.spd.hex M src/mainboard/google/poppy/spd/micron_dimm_MT40A512M16LY-075E.spd.hex M src/mainboard/google/poppy/spd/samsung_dimm_K4A4G165WE-BCRC.spd.hex 4 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/30909/6
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30909 )
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/30909/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/30909/1//COMMIT_MSG@12 PS1, Line 12: memeory
memory
Done
https://review.coreboot.org/#/c/30909/1//COMMIT_MSG@13 PS1, Line 13:
Was the memory part not booting before and now it's booting with this change?
the memory parts had been booting without this changes. the change is for the part number string, we need the correct part number strings in AV to apply the HW ID by the AVL part number.
Ren Kuo has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/30909 )
Change subject: mb/google/poppy/variants/nami: correct the spd data of memory parts ......................................................................
Abandoned