Change in coreboot[master]: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

7 Jul 2020 7 Jul '20

5:58 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43226 )

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

[TESTME] nb/intel/i945/early_init.c: Detect DMI link width

UNTESTED.

Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/i945/early_init.c 1 file changed, 6 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43226/1

diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c index f388330..cb5b520 100644 --- a/src/northbridge/intel/i945/early_init.c +++ b/src/northbridge/intel/i945/early_init.c @@ -399,11 +399,12 @@

reg32 = DMIBAR32(0x204); reg32 &= ~0x3ff; -#if 1 - reg32 |= 0x13f; /* for x4 DMI only */ -#else - reg32 |= 0x1e4; /* for x2 DMI only */ -#endif + + if (((DMIBAR16(DMILSTS) >> 4) & 0xf) == 2) + reg32 |= 0x1e4; /* for x2 DMI only */ + else + reg32 |= 0x13f; /* for x4 DMI only */ + DMIBAR32(0x204) = reg32;

if (pci_read_config8(PCI_DEV(0, 0x0, 0), DEVEN) & (DEVEN_D2F0 | DEVEN_D2F1)) {

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

HAOUAS Elyes (Code Review)

6 Aug 6 Aug

12:39 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43226 )

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

Patch Set 2:

there is no document ... however.. maybe this?

if (MSHBAR32(DFT_STRAP1) & (1 << 5) reg32 = 0xB13f; else reg32 = 0xB1e4;

(not tested and not documented)

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Aug 2020 15:39:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

12:48 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43226 )

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43226/2/src/northbridge/intel/i945/... File src/northbridge/intel/i945/early_init.c:

https://review.coreboot.org/c/coreboot/+/43226/2/src/northbridge/intel/i945/... PS2, Line 402: DMILSTS This needs to be DMILCAP instead, reg is 32-bit but the info is on the same bits

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Aug 2020 15:48:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

12:51 p.m.

Hello build bot (Jenkins), Stefan Reinauer, Maciej Matuszczyk, Arthur Heymans, Patrick Rudolph, HAOUAS Elyes,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43226

to look at the new patch set (#3).

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

[TESTME] nb/intel/i945/early_init.c: Detect DMI link width

UNTESTED.

Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/i945/early_init.c 1 file changed, 6 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43226/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

12:51 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43226 )

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43226/2/src/northbridge/intel/i945/... File src/northbridge/intel/i945/early_init.c:

https://review.coreboot.org/c/coreboot/+/43226/2/src/northbridge/intel/i945/... PS2, Line 402: DMILSTS

...

This needs to be DMILCAP instead, reg is 32-bit but the info is on the same bits

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 06 Aug 2020 15:51:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

12 Aug 12 Aug

2:39 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43226 )

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

Patch Set 3:

Maybe you can test on dell/gx520 ( https://review.coreboot.org/c/coreboot/+/29109 )?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 12 Aug 2020 05:39:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

7:32 a.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43226 )

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

Patch Set 3:

...

Patch Set 3:

Maybe you can test on dell/gx520 ( https://review.coreboot.org/c/coreboot/+/29109 )?

I don't have it with me.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 12 Aug 2020 10:32:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Maciej Matuszczyk (Code Review)

15 Aug 15 Aug

2:19 p.m.

Maciej Matuszczyk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43226 )

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

Patch Set 3: Code-Review+1

Tested on D945GCLF2 and it still boots, no change in DMIBAR+0x204

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 15 Aug 2020 17:19:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

30 Aug 30 Aug

8:29 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43226 )

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

Patch Set 3: Code-Review+1

tested on 945g-m4: using bios by NEC and by intel : DMIBAR(0x204) = 0x0000b13f

using coreboot: DMIBAR(0x204) = 0x0000d13f (same value with or without current patch).

I think it needs test for x2 DMI only

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 30 Aug 2020 11:29:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:38 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43226 )

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

Patch Set 3:

...

Patch Set 3: Code-Review+1

Tested on D945GCLF2 and it still boots, no change in DMIBAR+0x204

do you have the value using vendor bios ?

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 30 Aug 2020 11:38:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Maciej Matuszczyk (Code Review)

6:45 p.m.

Maciej Matuszczyk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43226 )

Change subject: [TESTME] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

Patch Set 3:

...

Patch Set 3:

...
Patch Set 3: Code-Review+1

Tested on D945GCLF2 and it still boots, no change in DMIBAR+0x204

do you have the value using vendor bios ?

No, I couldn't get D945GCLF2's vendor bios to boot from hdd, or any pendrive i tried. Value was taken from coreboot 4.11 or 4.12

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 30 Aug 2020 21:45:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

12 Mar 12 Mar

8:46 a.m.

New subject: Change in coreboot[master]: [TESTME?] nb/intel/i945/early_init.c: Detect DMI link width

Hello build bot (Jenkins), Stefan Reinauer, Maciej Matuszczyk, Arthur Heymans, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/43226

to look at the new patch set (#5).

Change subject: [TESTME?] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

[TESTME?] nb/intel/i945/early_init.c: Detect DMI link width

Tested for the x4 case on intel/d945gclf and NEC 945G-M4.

Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/i945/early_init.c 1 file changed, 6 insertions(+), 5 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/43226/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Martin L Roth (Code Review)

7 Aug 7 Aug

5:16 p.m.

New subject: [S] Change in coreboot[master]: [TESTME?] nb/intel/i945/early_init.c: Detect DMI link width

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43226?usp=email )

Change subject: [TESTME?] nb/intel/i945/early_init.c: Detect DMI link width ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/43226?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I79829fa8fc9b26abca9983b1e3dc3a137a0ba49b Gerrit-Change-Number: 43226 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Maciej Matuszczyk maccraft123mc@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

330

days inactive

1456

days old

coreboot-gerrit@coreboot.org

12 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Maciej Matuszczyk (Code Review)
Martin L Roth (Code Review)