Change in coreboot[master]: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed

List overview All Threads
Download

newer

older

[M] Change in libgfxinit[main]:...

[S] Change in coreboot[main]:...

Keith Hui (Code Review)

16 May 2020 16 May '20

5:04 a.m.

Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41458 )

Change subject: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed

This change reflects vendor setup for asus/p3b-f.

Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Signed-off-by: Keith Hui buurin@gmail.com --- M src/southbridge/intel/i82371eb/acpi/i82371eb.asl 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/41458/1

diff --git a/src/southbridge/intel/i82371eb/acpi/i82371eb.asl b/src/southbridge/intel/i82371eb/acpi/i82371eb.asl index 4a1b385..f0f6a0c 100644 --- a/src/southbridge/intel/i82371eb/acpi/i82371eb.asl +++ b/src/southbridge/intel/i82371eb/acpi/i82371eb.asl @@ -34,7 +34,9 @@ /* Aliased DMA ports */ IO (Decode16, 0x0010, 0x0010, 0x01, 0x10, ) /* Aliased PIC ports */ - IO (Decode16, 0x0022, 0x0022, 0x01, 0x1E, ) + /* Do not claim 0x2e-0x2f, per P3B-F vendor DSDT */ + IO (Decode16, 0x0022, 0x0022, 0x01, 0x0C, ) + IO (Decode16, 0x0030, 0x0030, 0x01, 0x10, ) /* Aliased timer ports */ IO (Decode16, 0x0050, 0x0050, 0x01, 0x04, ) IO (Decode16, 0x0062, 0x0062, 0x01, 0x02, )

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

Angel Pons (Code Review)

17 May 17 May

4:25 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41458 )

Change subject: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/41458/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41458/1//COMMIT_MSG@9 PS1, Line 9: This change reflects vendor setup for asus/p3b-f. What do other boards do?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 17 May 2020 14:25:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Keith Hui (Code Review)

26 May 26 May

6:31 p.m.

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41458 )

Change subject: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41458/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/41458/1//COMMIT_MSG@9 PS1, Line 9: This change reflects vendor setup for asus/p3b-f.

...

What do other boards do?

Others in p2b family do it the pre-patch way.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 26 May 2020 16:31:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Keith Hui (Code Review)

2 Feb 2 Feb

12:36 a.m.

New subject: [S] Change in coreboot[master]: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed

Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41458

to look at the new patch set (#6).

Change subject: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed

This change reflects vendor setup for asus/p3b-f.

Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Signed-off-by: Keith Hui buurin@gmail.com --- M src/southbridge/intel/i82371eb/acpi/i82371eb.asl 1 file changed, 15 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/41458/6

Paul Menzel (Code Review)

7:48 a.m.

New subject: [S] Change in coreboot[master]: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed

Attention is currently required from: Keith Hui.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41458 )

Change subject: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

Patch Set 6:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/41458/comment/03055ceb_3b3ea4d5 PS6, Line 10: What Linux(?) messages did you check to verify, it’s working?

Is that just to match the vendor firmware, or is also a problem fixed?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 6 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Keith Hui buurin@gmail.com Gerrit-Comment-Date: Thu, 02 Feb 2023 06:48:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Keith Hui (Code Review)

11:51 p.m.

New subject: [S] Change in coreboot[master]: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed

Attention is currently required from: Paul Menzel.

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41458 )

Change subject: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

Patch Set 6:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/41458/comment/b7410ebd_56bcddda PS6, Line 10:

...

What Linux(?) messages did you check to verify, it’s working? […]

Just to match vendor firmware. More resources may have to be left unclaimed to resolve the resource conflict that "necessitates" SCMI support in another patch. That though will be separate.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 6 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Comment-Date: Thu, 02 Feb 2023 22:51:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: comment

Keith Hui (Code Review)

16 Feb 16 Feb

6:01 p.m.

New subject: [S] Change in coreboot[master]: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed

Attention is currently required from: Paul Menzel.

Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41458 )

Change subject: sb/intel/i82371eb: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

Patch Set 6:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/41458/comment/02792b29_955dd7b7 PS6, Line 10:

...

Just to match vendor firmware. […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/41458 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 6 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Comment-Date: Thu, 16 Feb 2023 17:01:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org Comment-In-Reply-To: Keith Hui buurin@gmail.com Gerrit-MessageType: comment

Keith Hui (Code Review)

23 Jul 23 Jul

2:09 a.m.

New subject: [XS] Change in coreboot[main]: sb/intel/i82371eb/acpi: Leave I/O ports 0x2e-0x2f unclaimed

Attention is currently required from: Keith Hui, Paul Menzel.

Hello Angel Pons, Patrick Rudolph, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/41458?usp=email

to look at the new patch set (#7).

Change subject: sb/intel/i82371eb/acpi: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

sb/intel/i82371eb/acpi: Leave I/O ports 0x2e-0x2f unclaimed

This change reflects vendor setup for asus/p3b-f.

Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Signed-off-by: Keith Hui buurin@gmail.com --- M src/southbridge/intel/i82371eb/acpi/i82371eb.asl 1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/41458/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/41458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph rudolphpatrick05@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Keith Hui buurin@gmail.com

Angel Pons (Code Review)

7:04 a.m.

New subject: [XS] Change in coreboot[main]: sb/intel/i82371eb/acpi: Leave I/O ports 0x2e-0x2f unclaimed

Attention is currently required from: Keith Hui, Paul Menzel.

Angel Pons has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/41458?usp=email )

Change subject: sb/intel/i82371eb/acpi: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

Patch Set 7: Code-Review+1

(1 comment)

Patchset:

PS7: Does the Super I/O use these ports?

-- To view, visit https://review.coreboot.org/c/coreboot/+/41458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph rudolphpatrick05@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Keith Hui buurin@gmail.com Gerrit-Comment-Date: Tue, 23 Jul 2024 05:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

Keith Hui (Code Review)

12:41 p.m.

New subject: [XS] Change in coreboot[main]: sb/intel/i82371eb/acpi: Leave I/O ports 0x2e-0x2f unclaimed

Attention is currently required from: Angel Pons.

Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/41458?usp=email )

Change subject: sb/intel/i82371eb/acpi: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

Patch Set 7:

(1 comment)

Patchset:

PS7:

...

Does the Super I/O use these ports?

Usually yes.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph rudolphpatrick05@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Tue, 23 Jul 2024 10:41:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com

Angel Pons (Code Review)

7:44 p.m.

New subject: [XS] Change in coreboot[main]: sb/intel/i82371eb/acpi: Leave I/O ports 0x2e-0x2f unclaimed

Attention is currently required from: Keith Hui.

Angel Pons has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/41458?usp=email )

Change subject: sb/intel/i82371eb/acpi: Leave I/O ports 0x2e-0x2f unclaimed ......................................................................

Patch Set 7:

(1 comment)

Patchset:

PS7:

...

Usually yes.

If they're claimed by the Super I/O ASL, then I'm OK with this. In that case I'd expect this to fix some resource conflict.

-- To view, visit https://review.coreboot.org/c/coreboot/+/41458?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I11972b650d95a48e4d372defe201cc9e743d5b30 Gerrit-Change-Number: 41458 Gerrit-PatchSet: 7 Gerrit-Owner: Keith Hui buurin@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Patrick Rudolph rudolphpatrick05@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Keith Hui buurin@gmail.com Gerrit-Comment-Date: Tue, 23 Jul 2024 17:44:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Keith Hui buurin@gmail.com

122

days inactive

1651

days old

coreboot-gerrit@coreboot.org

10 comments

3 participants

tags (0)

participants (3)

Angel Pons (Code Review)
Keith Hui (Code Review)
Paul Menzel (Code Review)